Learn how easy it is to sync an existing GitHub or Google Code repo to a SourceForge project! See Demo

Close

#67 bugfix and enhancement for 8139too.c

closed-out-of-date
Jeff Garzik
4
2006-09-19
2001-06-03
Jeff Garzik
No

Date: Wed, 23 May 2001 13:33:00 +0200 (CEST)
From: Christian Krause <chkr@peppercon.com>
X-X-Sender: <chkr@localhost.localdomain>
To: Jeff Garzik <jgarzik@mandrakesoft.com>
Subject: bugfix and enhancement for 8139too.c
Message-ID:
<Pine.LNX.4.33.0105231102540.4239-300000@localhost.localdomain>
MIME-Version: 1.0

Hello,

1. I found a bug in 8139too when using PIO mode
(CONFIG_8139TOO_PIO).
In rtl1839_init_one the line "ioaddr = tp->mmio_addr;"
is dangerous,
because tp->mmio_addr has no valid value when using PIO
mode. You can find
a work-around in the attached patch
(linux-2.4.3-rtl8139bug.patch). This
patch fixes some compiler warnings when _not_ using
CONFIG_8139TOO_8129,
too.

2. Our company (www.peppercon.de) produces a NIC
("ROL/F"), based on
RTL8139 chip, which has additional features like "Reset
on Lan" or
"Watchdog support". Because of this I made some
modifications of the
8139too driver to support these features. Is it
possible to include
our changes in the official driver? (see attached
linux-2.4.3-rolf.patch)
If not: On which rules or conditions it depends?
These modifications doesn't do anything when no ROL/F
card is detected.

best regards,

christian krause
peppercon AG

Discussion

  • Jeff Garzik
    Jeff Garzik
    2001-06-03

    8139 support for ROL/F cards (64-bit)

     
  • Jeff Garzik
    Jeff Garzik
    2006-09-19

    • status: open --> closed-out-of-date
     
  • Jeff Garzik
    Jeff Garzik
    2006-09-19

    Logged In: YES
    user_id=17443

    Please report this to bugzilla.kernel.org.