Work at SourceForge, help us to make it a better place! We have an immediate need for a Support Technician in our San Francisco or Denver office.

Close

#2 ethtool enhancements

closed
Jeff Garzik
None
5
2002-08-09
2001-10-18
Anonymous
No

Hello dear developpers,
I packaged ethtool for Debian distribution last month
then I received request for enhancements from users,
especially when ethtool is talking to an ethernet
driver not supporting ETHTOOL_GSET. When ethtool is
called with no option on command line (just the
interface name) it reports 'Cannot get device settings:
Operation not supported' error for many cards (3c59x
for example). It suggest that something is wrong in the
system.
Therefore, could it be possible to treat no option as
"show driver settings" instead of "show card settings"?
Or better try both then reports only those that
succeeded. You could then add a -g option to trigger
only card settings retrieval.
Another useful option could be -v to display version
and copyright of ethtool, and ethtool called without
any argument could display all Ethernet adapters
available (maybe just all supporting SIOCETHTOOL
ioctl).
I can work on it and submit patches to you if you want.
Btw, I've had added backward compatibility with 2.2
kernel and Happy Meal Ethernet driver on sparc to your
ethtool 1.3 release. I can send you the diffs if you
want to integrate them in the upstream release (it is
important for Debian to still be compatible with 2.2
kernel series). I know it is some kind of hack due to
changes in the ethtool_cmd struct layout just before
the release of 2.4.0 kernel but I tried to write it as
most as cleanly I can, and it is not enabled by default
at compile time (you need to pass --enable-compat to
the configure step).
Regards.

Discussion

  • Jeff Garzik
    Jeff Garzik
    2001-11-01

    Logged In: YES
    user_id=17443

    I'm very interested in these patches. Generate diffs
    against current ethtool CVS (found here at SourceForge), and
    feel free to send me e-mail.

    Jeff

     
  • Jeff Garzik
    Jeff Garzik
    2001-11-01

    • assigned_to: nobody --> jgarzik
     
  • Jeff Garzik
    Jeff Garzik
    2002-08-09

    • status: open --> closed