#130 ethtool dump_supported missing 10GBase-T

closed
Jeff Garzik
misc (7)
5
2009-03-06
2007-09-20
Ben Hutchings
No

dump_supported() in ethtool doesn't check for SUPPORTED_10000baseT_Full. The output for a 10GBase-T (only) NIC is:

Settings for eth2:
Supported ports: [ TP ]
Supported link modes:
Supports auto-negotiation: No
Advertised link modes: 10000baseT/Full
Advertised auto-negotiation: No
Speed: 10000Mb/s
Duplex: Full
Port: Twisted Pair
PHYAD: 1
Transceiver: internal
Auto-negotiation: off
Current message level: 0x00000001 (1)
Link detected: no

It should be:

Settings for eth2:
Supported ports: [ TP ]
Supported link modes: 10000baseT/Full
Supports auto-negotiation: No
Advertised link modes: 10000baseT/Full
Advertised auto-negotiation: No
Speed: 10000Mb/s
Duplex: Full
Port: Twisted Pair
PHYAD: 1
Transceiver: internal
Auto-negotiation: off
Current message level: 0x00000001 (1)
Link detected: no

Discussion

  • Auke Kok
    Auke Kok
    2007-11-07

    Logged In: YES
    user_id=126698
    Originator: NO

    Patch for this was submitted by my colleague today. Check ethtool merge logs to see if it was accepted. It would help if you can test the patch for us and report this to netdev@vger.kernel.org.

    Cheers,

    Auke

     
  • Jeff Garzik
    Jeff Garzik
    2009-03-06

    • assigned_to: nobody --> jgarzik
    • status: open --> closed