#26 external player and temp dir

open
nobody
None
5
2006-05-20
2006-05-20
doggy
No

HI,
If I change the player to "external player" in the
interface and restart GIT it crashes with:

java.lang.reflect.InvocationTargetException
at sun.reflect.NativeConstructorAccessorImpl.
newInstance0(Native Method)
at sun.reflect.NativeConstructorAccessorImpl.
newInstance(NativeConstructorAccessorImpl.java:39)
at sun.reflect.
DelegatingConstructorAccessorImpl.newInstance
(DelegatingConstructorAccessorImpl.java:27)
at java.lang.reflect.Constructor.newInstance
(Constructor.java:274)
at org.git.client.swing.GITStartup.main
(GITStartup.java:57)
Caused by: java.lang.IllegalArgumentException:
setSelectedIndex: 2 out of bounds
at javax.swing.JComboBox.setSelectedIndex
(JComboBox.java:595)
at org.git.GITPropertiesPanel.createComponents
(GITPropertiesPanel.java:318)
at org.git.GITPropertiesPanel.<init
>(GITPropertiesPanel.java:106)
at org.git.client.swing.GetItTogether.
createCards(GetItTogether.java:2203)
at org.git.client.swing.GetItTogether.
createSplitPane(GetItTogether.java:2032)
at org.git.client.swing.GetItTogether.<init
>(GetItTogether.java:499)
... 5 more
creating xml...
writing XML to /media/Disk2/temp/git/git.xml ...
java.lang.NullPointerException
at org.git.client.swing.GetItTogether$9.run
(GetItTogether.java:450)

If I change the following line to:
<player type="1" volume="72" external_prog="/usr/bin/
xmms -e /media/git/" />
it works. I have to change type="2" to 1.

Also I need to add the path from where git is startet,
because the temporary file is downloaded to there and
apparently the external player needs the ABSOLUTE path.

Furthermore, the temp file is NOT downloaded to the
temporary directory.

Summary:
- combo-box entry is saved wrongly for some reason
- temp files are not downloaded to temp dir
- external player needs absolute path.

besides that ;-) great program good work!
It would be nice to be able to specify where the
config file(s) will be saved.

cheers florian

Discussion