Re: [Geotools-devel] Issue with ID filter serialization

[Jody G. <jod...@gm...>]

Not quite sure what to make of that ... the format for feature id is pretty
strict (to match XML use) and has to start with a letter?
I wonder if UUIDs are always valid feature ids? Or if we should prefix them
with the typename+"."+uuid ?

aside: Your pull request looks fine on initial inspection, that for
including a test.


Jody Garnett


On Thu, Aug 7, 2014 at 2:40 PM, Jim Hughes <jn...@cc...> wrote:

> Hi all,
>
> I think I've found a small issue with how ID filters are serialized by
> ECQL.toCQL.  From what I can gather from the ECQL grammar, an ID filter
> should either be "ID (number)" or "ID('string')".  The existent quote
> check in FilterToECQL checks to see if there are .'s in the string which
> I works when the ID scheme is fid.num.
>
> I've put in a ticket and pushed up a PR.
>
> Ticket: https://jira.codehaus.org/browse/GEOT-4870
> PR:      https://github.com/geotools/geotools/pull/524
>
> Thanks in advance for any feedback,
>
> Jim
>
>
>
> ------------------------------------------------------------------------------
> Infragistics Professional
> Build stunning WinForms apps today!
> Reboot your WinForms applications with our WinForms controls.
> Build a bridge from your legacy apps to the future.
>
> http://pubads.g.doubleclick.net/gampad/clk?id=153845071&iu=/4140/ostg.clktrk
> _______________________________________________
> GeoTools-Devel mailing list
> Geo...@li...
> https://lists.sourceforge.net/lists/listinfo/geotools-devel
>