From: Martin D. <md...@op...> - 2012-05-07 05:08:13
|
Looks to me like there are very few dependencies of ReferencedEnvelope on JTS.java - as far as I can see just a transform method (which is itself fairly light in terms of dependencies on the rest of the JTS class). So, it seems like it could be possible to move the bulk of the JTS class code out of gt-api - and then most of the other classes in the jts package would move with it. The particular transform method which is used could be factored out into a class called something like JTSTransform. Of course, this would need to be tested to confirm. And I have no experience with what might break if this was done. At very least perhaps the smoothing code could be moved? It really seems out of place in an api module. On Thu, May 3, 2012 at 11:37 PM, Jody Garnett <jod...@gm...>wrote: > Yep ReferncedEnvelope is the problem child that keeps us from combining > gt-api and gt-opengis as well. > > Any ideas are welcome ! > > > > On 04/05/2012, at 8:48 AM, Martin Davis <md...@op...> wrote: > > I looked into this in a bit more detail with Justin, and it seems like > there is some tenuous dependencies that would make it hard to just move the > classes as they stand. (E.g ReferencedEnvelope depends on JTS transform > methods). > > Still, it seems like it might be good to some light refactoring to move > some of the code into gt-main. For instance, perhaps the smoothing code > would better belong in main? > > On Thu, May 3, 2012 at 1:04 PM, Martin Davis <md...@op...> wrote: > >> There's a bunch of classes in org.geotools.geometry.jts in gt-api. It >> seems like these would be better off in gt-main, since that's where they >> are used. Is there any reason not to move them? >> >> The reason I ask is that I'm adding some code to the JTS class, but it >> uses other code which could be exposed and shared with gt-main. I don't >> want to keep adding JTS code to gt-api if that's just perpetuating the mess. >> >> -- >> Martin Davis >> OpenGeo - http://opengeo.org >> Expert service straight from the developers. >> >> > > > -- > Martin Davis > OpenGeo - http://opengeo.org > Expert service straight from the developers. > > > ------------------------------------------------------------------------------ > Live Security Virtual Conference > Exclusive live event will cover all the ways today's security and > threat landscape has changed and how IT managers can respond. Discussions > will include endpoint security, mobile security and the latest in malware > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > > _______________________________________________ > GeoTools-Devel mailing list > Geo...@li... > https://lists.sourceforge.net/lists/listinfo/geotools-devel > > -- Martin Davis OpenGeo - http://opengeo.org Expert service straight from the developers. |