From: Andrea A. <aa...@op...> - 2010-01-22 19:19:58
|
Anthony McCallum ha scritto: > Hi Andrea, > > Does that mean we should be able to get away with only using the > pre-existing tests in > http://svn.osgeo.org/geotools/branches/2.6.x/modules/library/jdbc/src/test/java/org/geotools/jdbc as > well as our created tests in > http://svn.osgeo.org/geotools/branches/2.6.x/modules/plugin/jdbc/jdbc-h2/src/test/java/org/geotools/data/ingres? You should be able to get away with only those. However your tests should be in: http://svn.osgeo.org/geotools/branches/2.6.x/modules/unsupported/jdbc/jdbc-ingres/src/test/java/org/geotools/data/ingres You cannot contribute a module and have it as supported as well, first you contribute the module, if then a long term maintainer is found, if it has enough test coverage and some basic documentation the module graduates in supported land > And as such we shouldn't need to do any further testing besides ensuring > our code passes those JUnit tests? No, that's not what I said. GeoTools modules should run self contained test cases. However I suggest you try your module as much as you can, with GeoServer and other applications (uDig comes to mind) to make sure it works as expected, both correctness and performance wise. If you find any issue you'll write a new self contained unit test that covers the problem and add it to the others. Cheers Andrea -- Andrea Aime OpenGeo - http://opengeo.org Expert service straight from the developers. |