From: Andrea A. <and...@al...> - 2006-06-20 16:07:39
|
Chris Holmes ha scritto: > Cool. I think the answer is that the general recommendation should be > that code formatting is used. If a module maintainer feels strongly > against it, they can turn it off on their module and not let people code. > > I do think autoformatting may be lead to some pain initially (though > only because people haven't been doing it), but in the long run is much, > much better, and once the system is in place it will ensure that there > won't be nasty changes. But we should strongly enforce not formatting > code _with_ a bug fix, developers should make sure the fix and the > formatting are separate commits. This is what I always do, and lets one > easily determine what's different. The nice thing about autoformat during the build is that you don't really need to split the two. If the old code was already formatted, and you fix a bug, the next build will alter the fix only if you did not follow the coding conventions, so in the end the net result is that you have code properly formatted before the fix, and you commit a properly formatted fix. Cheers Andrea |