Re: [Geotools-devel] JDBCDataStore.JDBCFeatureWriter FIDs

[Sean G. <se...@sm...>]

The current method is a very temporary way of doing it, just so we could 
getting an initial version working.

There are a couple of issues with handling this correctly though. If the 
database table has not been set up with a trigger, leaving the field 
empty will result in errors on inserting. There is no easy way that I am 
aware of in JDBC to check if this exists. The previous method was to 
manually increment the max fid in the fid column, this is an improvement 
over current way in the JDBCDataStore but still doesn't account for 
triggers, concurrency or sequences.

Any suggestions of good ways to handle this would be appreciated.

Sean

Simon Räss wrote:

> How are fids calculated when a new Feature is written to the data 
> store? As far as I can tell, it is calculated within the 
> JDBCFeatureWriter.doInsert method. If so, I don’t like it. I’d prefer 
> to leave the fid field empty and let the database calculate it for me 
> (before insert trigger…).
>
> Simon
>