From: Justin D. <jde...@op...> - 2009-07-01 05:08:23
|
Joshua M. Thompson wrote: > On Tue, Jun 30, 2009 at 11:41 AM, Andrea Aime<aa...@op...> wrote: >> Basically, we could to remove the file when you press submit, but >> then you might not end up pressing apply/save, and when apply/save >> are pressed, we have no way to tell which style was removed anymore >> (because there is nothing keeping track of that). >> >> I believe this issue should not affect GeoServer 2.0, at least there >> we have the certainty about what's about to be removed and we should >> be able to remove the sld files as well. > > Personally I've always thought of this as a feature rather than a bug. > It's nice knowing that even if someone deletes a style I still have > the file on the server. What would also be a nice improvement here is > if when you try to add a style and the file already exists it would > pick up that existing style right away. Currently it fails because it > wants to write the file and it already exists, so you have to go move > the file out of the way and then use its contents to recreate the > style as if it were brand new. Agreed, I think that is the real reason this was never done, to avoid permanently deleting data. But the apply save problem is definitely an issue as well. In 2.0 it should be easy enough to add a flag to the delete that will allow the user to physically delete the underlying SLD file. Feel free to open a jira anyone. -Justin > -- Justin Deoliveira OpenGeo - http://opengeo.org Enterprise support for open source geospatial. |