#16 China default should be Shanghai, not Chongqing?

open
nobody
None
5
2010-02-10
2010-02-10
Colin Watson
No

We received an Ubuntu bug report
(https://bugs.launchpad.net/ubuntu/+source/geoip/+bug/517621) from a Chinese user indicating that Asia/Shanghai would be a more appropriate default for China than Asia/Chongqing. (Note that Asia/Beijing, mentioned in the bug report, does not exist in the standard tz database; Asia/Shanghai covers that region.)

After a bit of digging, I narrowed this down to GeoIP lookups always returning Chongqing for China:

else if ( strcmp (country, "CN") == 0 ) {
timezone = "Asia/Chongqing";
}

Could this be changed to Asia/Shanghai instead?

Discussion

  • Boris Zentner
    Boris Zentner
    2010-02-24

    Hi Collin,

    thanks for that. I add all missing timezones, to the cvs and the upcomming 1.4.7.