From: Emil Brink <emil@ob...> - 2005-10-26 21:10:22
While actually taking a look at gentoo today, I found a small problem
that made gentoo fail when copying files, if it could not also copy
the protection bits. Because many file systems (such as Samba) does
not support copying of Unix-style bits, this is a common problem.
It is common enough for there to be an option to make the Copy command
ignore the failure to copy protection bits. Unfortunately, the code
for that option was broken.
diff -pruN gentoo-0.11.55/src/cmd_copy.c gentoo-0.11.56/src/cmd_copy.c
--- gentoo-0.11.55/src/cmd_copy.c 2004-12-27 21:17:09.000000000 +0100
+++ gentoo-0.11.56/src/cmd_copy.c 2005-10-27 00:19:08.000000000 +0200
@@ -122,9 +122,9 @@ static gboolean copy_attributes(const ch
copy_dates(from, from_stat, to);
copy_mode(from, from_stat, to);
copy_owner(from, from_stat, to);
- ret = errno == 0;
errno = old_errno;
+ ret = errno == 0;
Is believed to improve the situation.
I don't *think* this is the problem people talked about earlier in
the Ubuntu Breezy thread, but it might be related. If you would like
to give it a try, that'd be appreciated.