#137 Redesign of CharGen for BG1

closed-fixed
nobody
GUIScripts (38)
5
2009-07-01
2009-06-07
danamin
No

A wizard-like implementation of the character generator for BG1

-Import function doesn't work (but it didn't work before the patch)
-all other functions work with BG1 and TotS (for me at least)

Install
-appy patch and install new files
-remove CharGen[2-9].py

Discussion

  • danamin
    danamin
    2009-06-07

    patch for GUICGXX and new files

     
  • Jaka Kranjc
    Jaka Kranjc
    2009-06-07

    Are there any improvements to this since last night?

    btw, diff/patch can handle removing and adding files, you just have to pass -N for the new ones.

     
  • danamin
    danamin
    2009-06-14

    second version, more like BG2

     
    Attachments
  • danamin
    danamin
    2009-06-14

    BG2 part of the chargenpatch, pulling up some shared functionality with BG1

     
    Attachments
  • Jaka Kranjc
    Jaka Kranjc
    2009-06-15

    the common chunks have been split, fixed up and committed. I've generalised LUSpellSelection(s) and added it to the root. The rest of the bg1 chargen is untouched and untested (I don't have bg1 installed).

    Are there still any problems that you are aware of? Verbosity is a virtue. ;)

     
  • Jaka Kranjc
    Jaka Kranjc
    2009-06-15

    the not applied parts of the patches

     
    Attachments
  • Alyssa Milburn
    Alyssa Milburn
    2009-06-15

    My observations so far:

    The "Import" button no longer works, it reports a missing function.
    The sprites shown for the proficiency slots are wrong, and it lets me assign too many proficiencies. Is this a bug with the merged common chunks?
    gemrb segfaults when it tries to remove spells from the spellbook, I'll take a look at that.
    And we haven't applied the GTable.GetValue patch, so you can't click accept.

     
  • danamin
    danamin
    2009-06-16

    fixed wrong sprite in proficiency select and import button

     
    Attachments
  • Alyssa Milburn
    Alyssa Milburn
    2009-06-16

    Still some proficiency bugs, sorry:

    The "Large Sword" proficiency is missing when I make a thief (maybe also for other classes?)

    You should only be able to put at most 2 points into a proficiency as a fighter, not all 4.

    I also found some more bugs that are not important, I just thought I would mention them:

    The summary should say "Gender: Male" and not "Male", and Class should be displayed above Race (except if Class has not been selected yet).

    The 'skills' screen for thieves should show things like '5%' for the skill levels, and the text should say something like "30 extra percentage points" (the number is missing in the patch).

    The summary should also say things like '5%' for the proficiencies.

    The proficiency screen should say "You cannot further specialize in this proficiency" when you try clicking + and you put too many points in the slot already.

    The default colours for Appearance are not right (the clothes should be green, for example).

     
  • Alyssa Milburn
    Alyssa Milburn
    2009-06-17

    Hm, if you click 'mutli-class' when creating a Gnome, you get the wrong strings appearing on the buttons which list the classes.

     
  • Alyssa Milburn
    Alyssa Milburn
    2009-06-17

    These bugs are all regressions from the old chargen and should be fixed:

    Missing number in the description text for thief skills.
    "Large Sword" proficiency missing for many classes.
    Should only be able to put at most 2 points into a proficiency as a fighter.
    Summary should say "Gender: Male" and not "Male".

    These bugs needn't be fixed because they were broken in the old chargen:

    The multi-class/gnome strings bug (mageschool is not handled properly).
    The missing % sign in the summary/skills dialog for thieves.
    The default Appearance colours.
    The proficiency screen "You cannot further specialize in this proficiency" statement.

     
  • danamin
    danamin
    2009-06-17

    fixed segfault,props and gender

     
    Attachments
  • Alyssa Milburn
    Alyssa Milburn
    2009-06-22

    I applied everything here and everything discussed on IRC after I finally found the cause of the segfaults. Thanks!

     
  • Alyssa Milburn
    Alyssa Milburn
    2009-06-22

    • status: open --> open-fixed
     
  • Alyssa Milburn
    Alyssa Milburn
    2009-07-01

    • status: open-fixed --> closed-fixed