Learn how easy it is to sync an existing GitHub or Google Code repo to a SourceForge project! See Demo

Close

Commit [4efcba] Maximize Restore History

Include what you use

This is a mega-commit - because most of it had to be done in one go
otherwise some commits would fail to compile - that attempts to fix a
few problems with Geany's includes as well as various other related
cleanups. After this change it's easier to use includes and there's
little worry about which order things are included in or who includes
what.

Overview of changes:

* Include config.h at the start of each source file if HAVE_CONFIG_H
is defined (and never in headers).
* Go through each source file and make the includes section generally
like this:
- Always config.h first as above
- Then if the file has a header with the same name, include that
- Then include in alphabetical order each other internal/geany header.
- Then include standard headers
- Then include non-standard system headers
- Then include GLib/GTK+ related stuff
* Doing as above makes it easier to find implicit header include
dependencies and it exposed quite a few weird problems with includes
or forward declarations, fix those.
* Make geany.h contain not much besides some defines.
- Add a little header file "app.h" for GeanyApp and move it there
- Move "app" global to new "app.h" file
- Move "ignore_callback" global to "callbacks.h"
- Move "geany_object" global to "geanyobject.h"
* Add an include in "geany.h" for "app.h" since GeanyApp used to be
defined there and some plugins included this header to access
GeanyApp.
* Include "gtkcompat.h" everywhere instead of gtk/gtk.h so that
everywhere sees the same definitions (not a problem in practice AFAIK
so this could be changed back if better that way.
* Remove forward declarations from previous commits as some people
apparently consider this bad style, despite that it reduces inter-
header dependencies.

TODO:
* As always, to test on win32
* As always, to test with not Autotools
* Test plugins better, both builtin and geany-plugins, likely API/ABI bump
* Test with various defines/flags that may change what is included
* win32.[ch] not really touched since I couldn't test

Matthew Brush Matthew Brush 2014-05-19

1 2 3 4 > >> (Page 1 of 4)
changed plugins/geanyplugin.h
changed src/Makefile.am
changed src/about.c
changed src/build.c
changed src/build.h
changed src/callbacks.c
changed src/callbacks.h
changed src/dialogs.c
changed src/dialogs.h
changed src/document.c
changed src/document.h
changed src/documentprivate.h
changed src/editor.c
changed src/editor.h
changed src/encodings.c
changed src/encodings.h
changed src/filetypes.c
changed src/filetypes.h
changed src/filetypesprivate.h
changed src/gb.c
changed src/geany.h
changed src/geanyentryaction.c
changed src/geanyentryaction.h
changed src/geanymenubuttonaction.c
changed src/geanymenubuttonaction.h
plugins/geanyplugin.h Diff Switch to side-by-side view
Loading...
src/Makefile.am Diff Switch to side-by-side view
Loading...
src/about.c Diff Switch to side-by-side view
Loading...
src/build.c Diff Switch to side-by-side view
Loading...
src/build.h Diff Switch to side-by-side view
Loading...
src/callbacks.c Diff Switch to side-by-side view
Loading...
src/callbacks.h Diff Switch to side-by-side view
Loading...
src/dialogs.c Diff Switch to side-by-side view
Loading...
src/dialogs.h Diff Switch to side-by-side view
Loading...
src/document.c Diff Switch to side-by-side view
Loading...
src/document.h Diff Switch to side-by-side view
Loading...
src/documentprivate.h Diff Switch to side-by-side view
Loading...
src/editor.c Diff Switch to side-by-side view
Loading...
src/editor.h Diff Switch to side-by-side view
Loading...
src/encodings.c Diff Switch to side-by-side view
Loading...
src/encodings.h Diff Switch to side-by-side view
Loading...
src/filetypes.c Diff Switch to side-by-side view
Loading...
src/filetypes.h Diff Switch to side-by-side view
Loading...
src/filetypesprivate.h Diff Switch to side-by-side view
Loading...
src/gb.c Diff Switch to side-by-side view
Loading...
src/geany.h Diff Switch to side-by-side view
Loading...
src/geanyentryaction.c Diff Switch to side-by-side view
Loading...
src/geanyentryaction.h Diff Switch to side-by-side view
Loading...
src/geanymenubuttonaction.c Diff Switch to side-by-side view
Loading...
src/geanymenubuttonaction.h Diff Switch to side-by-side view
Loading...
1 2 3 4 > >> (Page 1 of 4)