Learn how easy it is to sync an existing GitHub or Google Code repo to a SourceForge project! See Demo

Close

#33 [treebrowser] Missing declaration for creat()

trunk
closed-fixed
None
5
2012-05-07
2010-05-23
No

The treebrowser plugins misses some include for creat(), which is then not defined explicitly [1].

Joined a naive patch that includes the needed headers. Not guaranteed to work on non-POSIX systems.

[1] which may easily lead to strange bugs if the function is wrongly used since the compiler won't report it. Ah, and it breaks my builds with -Werror-implicit-function-declaration :-'

Discussion

  • Enrico Tröger
    Enrico Tröger
    2010-05-23

    On Windows, it compiles with the patch.
    Though, it still might be good to explicitly check for those headers (fnctl & sys/types.h) in the build system. We do this for Geany.

     
  • Enrico Tröger
    Enrico Tröger
    2010-05-23

    • assigned_to: nobody --> dimitrov-adrian
     
  • I would really like to see this fixed.
    OK, I may change my compiler flags not to fail on such errors, but as I already said I would think it is a quite serious problem.

    I attach two more patches that adds the correct checks for the build systems, as suggested below by Enrico.

     
  • It was actually fixed in SVNr1517 (364b5fa4), so I close it

     
    • status: open --> closed-fixed