Commit [c41d68] Maximize Restore History

compat: Make compat_alloc_user_space() incorporate the access_ok()

compat_alloc_user_space() expects the caller to independently call
access_ok() to verify the returned area. A missing call could
introduce problems on some architectures.

This patch incorporates the access_ok() check into
compat_alloc_user_space() and also adds a sanity check on the length.
The existing compat_alloc_user_space() implementations are renamed
arch_compat_alloc_user_space() and are used as part of the
implementation of the new global function.

This patch assumes NULL will cause __get_user()/__put_user() to either
fail or access userspace on all architectures. This should be
followed by checking the return value of compat_access_user_space()
for NULL in the callers, at which time the access_ok() in the callers
can also be removed.

Reported-by: Ben Hawkes <hawkes@sota.gen.nz>
Signed-off-by: H. Peter Anvin <hpa@linux.intel.com>
Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Acked-by: Chris Metcalf <cmetcalf@tilera.com>
Acked-by: David S. Miller <davem@davemloft.net>
Acked-by: Ingo Molnar <mingo@elte.hu>
Acked-by: Thomas Gleixner <tglx@linutronix.de>
Acked-by: Tony Luck <tony.luck@intel.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Fenghua Yu <fenghua.yu@intel.com>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Heiko Carstens <heiko.carstens@de.ibm.com>
Cc: Helge Deller <deller@gmx.de>
Cc: James Bottomley <jejb@parisc-linux.org>
Cc: Kyle McMartin <kyle@mcmartin.ca>
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Ralf Baechle <ralf@linux-mips.org>
Cc: <stable@kernel.org>

H. Peter Anvin H. Peter Anvin 2010-09-07

changed arch/ia64/include/asm/compat.h
changed arch/mips/include/asm/compat.h
changed arch/parisc/include/asm/compat.h
changed arch/powerpc/include/asm/compat.h
changed arch/s390/include/asm/compat.h
changed arch/sparc/include/asm/compat.h
changed arch/tile/include/asm/compat.h
changed arch/x86/include/asm/compat.h
changed include/linux/compat.h
changed kernel/compat.c
arch/ia64/include/asm/compat.h Diff Switch to side-by-side view
Loading...
arch/mips/include/asm/compat.h Diff Switch to side-by-side view
Loading...
arch/parisc/include/asm/compat.h Diff Switch to side-by-side view
Loading...
arch/powerpc/include/asm/compat.h Diff Switch to side-by-side view
Loading...
arch/s390/include/asm/compat.h Diff Switch to side-by-side view
Loading...
arch/sparc/include/asm/compat.h Diff Switch to side-by-side view
Loading...
arch/tile/include/asm/compat.h Diff Switch to side-by-side view
Loading...
arch/x86/include/asm/compat.h Diff Switch to side-by-side view
Loading...
include/linux/compat.h Diff Switch to side-by-side view
Loading...
kernel/compat.c Diff Switch to side-by-side view
Loading...