Re: [Dri-devel] Re: [GATOS]Re: Bugfix for br0ken DMA on r128 andp ossibly radeonDMA functions

[Keith W. <ke...@tu...>]

Vladimir Dergachev wrote:
> 
> On Wed, 30 Jan 2002, Gareth Hughes wrote:
> 
> > > Gareth, the current driver is broken. If someone wants to use video
> > > capture they _need_ both GATOS 2d driver and GATOS drm driver, period.
> > >
> > > What's so wrong about upgrading ?
> >
> > Guaranteed, someone will get a mismatch -- your changes may go back
> > into the stock kernel, breaking DRI CVS or whatever, who knows.  Forcing
> > everyone to upgrade their kernel, 2D and 3D drivers to the right magic
> > revision is a recipe for disaster, one that the kernel people have
> > already kicked our arses over (rightly so).
> >
> > > Also, I can make drm driver work nice with older 2d drivers - as soon as
> > > someone will show me a way to tell the version of the 2d driver that is
> > > accessing the drm driver.
> >
> > Sounds like it'll need a 2D driver upgrade :-)
> >
> 
> So what are you proposing ? Not to fix it ? We have a system where a
> driver is split in three components all of which have to agree on the
> hardware state. There is just so much you can do for backward
> compatibility. You can do less if you can't find one component version
> from another one.

Do it the old way by default, and if you receive some new ioctl, do it the new
way.

> As for Linus not wanting to accept it, 2.4 has dropped most nat filters
> except for ftp and most of them aren't back yet. So I don't buy this
> argument.

Trust us.  It's the right thing to do, whether Linus or anybody else says so.

Keith