[Ganglia-svn] SF.net SVN: ganglia:[1829] branches/monitor-core-3.1

[<ca...@us...>]

Revision: 1829
          http://ganglia.svn.sourceforge.net/ganglia/?rev=1829&view=rev
Author:   carenas
Date:     2008-09-26 05:45:41 +0000 (Fri, 26 Sep 2008)

Log Message:
-----------
web: metric group enhancements for host view

Add anchors to metric groups for direct linking and a count of the number
of metrics available for each group as proposed in BUG203

  svn merge -c 1711 trunk
  svn merge -c 1714 trunk

Reviewed-by: Jesse Becker <ha...@gm...>
Signed-off-by: Carlo Marcelo Arenas Belon <ca...@sa...>
Signed-off-by: Gilad Raphaelli <gra...@ya...>

Modified Paths:
--------------
    branches/monitor-core-3.1/STATUS
    branches/monitor-core-3.1/web/host_view.php
    branches/monitor-core-3.1/web/templates/default/host_view.tpl

Modified: branches/monitor-core-3.1/STATUS
===================================================================
--- branches/monitor-core-3.1/STATUS	2008-09-26 05:29:18 UTC (rev 1828)
+++ branches/monitor-core-3.1/STATUS	2008-09-26 05:45:41 UTC (rev 1829)
@@ -33,6 +33,7 @@
   * gmond: reformat memory metrics to match pre 3.1 style
   * web: add boolean option for using hostname without domainname for graphs
   * web: add host atrributes into metric list (BUG30)
+  * web: metric group enhancements for host view (BUG203)
   * Bug fixes and Enhancements
 
 RELEASE SHOWSTOPPERS:
@@ -137,12 +138,6 @@
     http://ganglia.svn.sourceforge.net/viewvc/ganglia?view=rev&revision=1708
     http://ganglia.svn.sourceforge.net/viewvc/ganglia?view=rev&revision=1754
 
-  * web: metric group enhancements for host view
-    http://bugzilla.ganglia.info/cgi-bin/bugzilla/show_bug.cgi?id=203
-    http://ganglia.svn.sourceforge.net/viewvc/ganglia?view=rev&revision=1711
-    http://ganglia.svn.sourceforge.net/viewvc/ganglia?view=rev&revision=1714
-    +1: carenas, hawson
-
   * build: clarify/update use of  "dist" targets
     http://bugzilla.ganglia.info/cgi-bin/bugzilla/show_bug.cgi?id=202
     http://ganglia.svn.sourceforge.net/viewvc/ganglia?view=rev&revision=1726

Modified: branches/monitor-core-3.1/web/host_view.php
===================================================================
--- branches/monitor-core-3.1/web/host_view.php	2008-09-26 05:29:18 UTC (rev 1828)
+++ branches/monitor-core-3.1/web/host_view.php	2008-09-26 05:45:41 UTC (rev 1829)
@@ -150,6 +150,7 @@
 	    }
             $tpl->newBlock("vol_group_info");
             $tpl->assign("group", $group);
+            $tpl->assign("group_metric_count", count($metric_array));
             $i = 0;
             ksort($g_metrics);
             foreach ( $g_metrics as $name => $v )

Modified: branches/monitor-core-3.1/web/templates/default/host_view.tpl
===================================================================
--- branches/monitor-core-3.1/web/templates/default/host_view.tpl	2008-09-26 05:29:18 UTC (rev 1828)
+++ branches/monitor-core-3.1/web/templates/default/host_view.tpl	2008-09-26 05:45:41 UTC (rev 1829)
@@ -102,11 +102,11 @@
  <TD>
 
 <!-- START BLOCK : vol_group_info -->
-<A HREF="javascript:;" ONMOUSEDOWN="javascript:toggleLayer('{group}');" TITLE="Toggle {group} metrics group on/off">
+<A HREF="javascript:;" ONMOUSEDOWN="javascript:toggleLayer('{group}');" TITLE="Toggle {group} metrics group on/off" NAME="{group}">
 <TABLE BORDER="0" WIDTH="100%">
 <TR>
   <TD CLASS=metric>
-  {group} metrics
+  {group} metrics ({group_metric_count})
   </TD>
 </TR>
 </TABLE>


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.