This all makes sense, thanks for catching it Jens. I was having "issues" adding the quick pane div to photo_top and photo_bottom. 

I'll review and correct.

On Mar 31, 2009, at 1:57 AM, Andy Staudacher <> wrote:

good catch.

there's no "resize" type (see the definition in core/models/item.php).
every item has a resize and a thumb. there's no resize object. you get the resize path or its <img> tag via the item.

the change in
doesn't look right.

 - andy

On Tue, Mar 31, 2009 at 12:43 AM, Jens A. Tkotz <> wrote:

i just read the commit 20516 for file

and saw a little strange use of $item->type

I can see the following types:

- album
- photo
- movie

And now added "resize".
According to the type the action can be chosen.

_To me_ this type is not suitable to the others. For me "resize" is
more like a characteristic of a type.

What is especially strange to me is this:
(($item->is_photo() || $item->type == "resize")

In theory this could indicate, that there are items that are not
photos, but resized?

In short, i suggest not to use the type attribute to identify a
resized photo and instead another attribute.
I am not going to do this, so if you are fine with the current way, i
am either :-)

- Jens

__[ g a l l e r y - d e v e l ]_________________________

[ list info/archive --> ]
[ gallery info/FAQ/download --> ]