#20 make _("Not in Roster") in UTF-8

closed-accepted
Brandon
interface (6)
5
2001-11-25
2001-08-28
Jungshik Shin
No

This is a simple one-liner to make
_("Not in Roster") in UTF-8 when calling addToGroup()
method for Roster item class.
Judging from other invocations of addToGroup(),
it expects its argument in UTF-8, but in
src/RosterView.cc, it's handed a string in
the encoding of the locale, instead.

Discussion

  • Jungshik Shin
    Jungshik Shin
    2001-08-28

    RosterView.cc patch

     
    Attachments
  • Jungshik Shin
    Jungshik Shin
    2001-08-28

    • summary: make ("Not in Roster") in UTF-8 --> make ("Not in Roster") in UTF-8
     
  • Jungshik Shin
    Jungshik Shin
    2001-08-28

    Logged In: YES
    user_id=307557

    I forgot to add my patch. The patch is made up of
    a simple one line patch to RosterView.cc along
    with patch to GabberUtility.cc and GabberUtility.hh
    to overload toUTF8() to get it to work with a single
    argument of type string.

     
  • Brandon
    Brandon
    2001-09-05

    • summary: make ("Not in Roster") in UTF-8 --> make ("Not in Roster") in UTF-8
    • assigned_to: nobody --> brandon2
     
  • Brandon
    Brandon
    2001-09-05

    Logged In: YES
    user_id=19497

    I'll take a look at it, will probably apply it to the tree sometime tonight.

     
  • Jungshik Shin
    Jungshik Shin
    2001-09-05

    Logged In: YES
    user_id=307557

    Thank you for looking at it. BTW, you don't have
    to apply my patches for GabberUtility.cc and GabberUtility.hh
    because they have already been applied to fix other
    problems. Only thing to be patched is a simple one-liner
    for RosterView.cc

     
  • Jungshik Shin
    Jungshik Shin
    2001-09-05

    • summary: make ("Not in Roster") in UTF-8 --> make ("Not in Roster") in UTF-8
     
  • Brandon
    Brandon
    2001-11-25

    • summary: make ("Not in Roster") in UTF-8 --> make ("Not in Roster") in UTF-8
    • status: open --> closed-accepted
     
  • Brandon
    Brandon
    2001-11-25

    Logged In: YES
    user_id=19497

    Yay, I finally checked this in. It's only been what, 3
    months? :)