Re: [fuse-devel] [PATCH v2 2/2] fuse: permit O_DIRECT flag in open()

[Christoph H. <hc...@in...>]

On Thu, Jul 28, 2011 at 01:44:08PM +0530, Anand Avati wrote:
> FUSE already has a direct IO implementation (struct file_operations
> fuse_direct_io_file_operation) but is currently set as a file's f_ops
> only based on flags returned from the filesystem server (in the reply
> of an open() call). This patch just lets the filesystem server know a
> userspace application's intention to open a file with O_DIRECT and
> leaves it with the decision to pick direct IO mode on the file (just
> the way it already does before the patch.) There is already a
> framework for direct IO operations and this patch only bridges
> O_DIRECT flag with that framework. Do you still think this is entirely
> incorrect?

Your clearing of the O_DIRECT flag is.  The current handling of O_DIRECT
in the VFS is a bit nasty, but if you have an issue with that fix it up
properly instead of piling more hacks on top of it.