Menu
▾
▴
[fuse-emulator-devel] [ fuse-emulator-Patches-3534182 ] Avoid deprecated combobox functions on GTK3 builds
|
From: SourceForge.net <no...@so...> - 2012-06-18 13:17:19
|
Patches item #3534182, was opened at 2012-06-10 12:19 Message generated for change (Settings changed) made by fredm You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=596650&aid=3534182&group_id=91293 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None >Status: Pending >Resolution: Accepted Priority: 5 Private: No Submitted By: Sergio Baldovi (sbaldovi) Assigned to: Nobody/Anonymous (nobody) Summary: Avoid deprecated combobox functions on GTK3 builds Initial Comment: This patch replace gtk_combo_box_new_text and gtk_combo_box_append_text symbols with gtk_combo_box_text_new and gtk_combo_box_text_append_text. Only with GTK3 builds because GtkComboBoxText is a far recent object. ---------------------------------------------------------------------- Comment By: Fredrick Meunier (fredm) Date: 2012-06-18 06:16 Message: Thanks, committed in revision 4720 ---------------------------------------------------------------------- Comment By: Sergio Baldovi (sbaldovi) Date: 2012-06-13 14:46 Message: Here is a simpler patch based on Alberto's suggestion. ---------------------------------------------------------------------- Comment By: Alberto Garcia (bertogg) Date: 2012-06-12 00:02 Message: I can do it but I don't know if I'll have much time these days, so feel free to go ahead. In the file that I pointed to you can find other similar solutions for keeping GTK+ 2 compatibility while using the GTK+ 3 API. ---------------------------------------------------------------------- Comment By: Sergio Baldovi (sbaldovi) Date: 2012-06-11 15:30 Message: You are right. It's better to use only the new syntax, if it is possible. I'll rethink this patch soon (unless you are keen to do it :) Thanks. ---------------------------------------------------------------------- Comment By: Alberto Garcia (bertogg) Date: 2012-06-11 14:15 Message: One alternative solution to avoid having #ifdefs in the middle of the code: https://gitorious.org/vagalume/vagalume/blobs/master/src/compat.h#line115 ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=596650&aid=3534182&group_id=91293 |