[fuse-emulator-devel] [ fuse-emulator-Patches-2637346 ] "combo box" for options.dat

SourceForge Headquarters 225 Broadway Suite 1600 San Diego, CA 92101 +1 (858) 454-5900

Patches item #2637346, was opened at 2009-02-25 15:28
Message generated for change (Comment added) made by sf-robot
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=596650&aid=2637346&group_id=91293

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
>Status: Closed
Resolution: Accepted
Priority: 5
Private: No
Submitted By: Gergely Szasz (szaszg)
Assigned to: Nobody/Anonymous (nobody)
Summary: "combo box" for options.dat

Initial Comment:
This patch adds a new type option entry: "Combo"
This is a text option, you can select one from a defined set.
An example combo definition in `ui/options.dat':
Combo, option text, variable_name, INPUT_KEY_, item 1|item 2|item 3

items separated by pipe (|). `variable_name' is a `string' in `settings.dat'.
If you set `variable_name' to a value which does not match any of item list, combo box show the first item.

There is no win32 code... (Marek?)

----------------------------------------------------------------------

>Comment By: SourceForge Robot (sf-robot)
Date: 2009-03-29 02:20

Message:
This Tracker item was closed automatically by the system. It was
previously set to a Pending status, and the original submitter
did not respond within 14 days (the time period specified by
the administrator of this Tracker).

----------------------------------------------------------------------

Comment By: Fredrick Meunier (fredm)
Date: 2009-03-15 01:29

Message:
Thanks, committed in revision 3990.

The light grey comes straight from FuseX - happy to have a different
colour as long as it is used consistently.

----------------------------------------------------------------------

Comment By: Gergely Szasz (szaszg)
Date: 2009-03-13 09:41

Message:
Hi!
Here is an updated patch. It included 4 combo box (test) option in the
Options->RZX options 'option tab'.
File Added: fuse.combo_06.diff

----------------------------------------------------------------------

Comment By: Gergely Szasz (szaszg)
Date: 2009-03-08 22:23

Message:
The patch...
File Added: fuse.combo_05.diff

----------------------------------------------------------------------

Comment By: Gergely Szasz (szaszg)
Date: 2009-03-08 22:20

Message:
Hmm... here is a new patch. Now, `gtk/options.pl' reduce combo def. and
code multiplications in the same way as `widget/options.pl'.
Now, the combo text is gray. (imho: the visibility is terrible...)

"...(e.g. enter on a "combo" item goes to the "combo select" screen..."
hmm.. The key handling works uniformly on option pages: e.g. [space] ->
`click on' current option entry (check/uncheck checkbox, open entry widget,
and open combo selection), [enter] -> close option 'page' and set options,
[esc] -> close option 'page' and revert options.

So, if we use [enter] for open `combo select', we `break' the options tab
'working behaviour' ...

This patch include the #2673198 bug fix, and an additional flag to
'general select' widget, to avoid closing options tab after exit 'combo
selection'.

IMHO this [ENTER] -> set options & close tab behaviour is very annoying
thing... (we may need an explicit [OK] entry or something like...)

----------------------------------------------------------------------

Comment By: Fredrick Meunier (fredm)
Date: 2009-03-07 12:49

Message:
Yes, same gray text for currently selected item (the back right "arrow" is
for items with submenus) and also with the same key handling (e.g. enter on
a "combo" item goes to the "combo select" screen, along with any other
changes you notice to keep the behaviour the same as the general widget UI.

----------------------------------------------------------------------

Comment By: Gergely Szasz (szaszg)
Date: 2009-03-04 19:37

Message:
This patch handle the multiple time defined sets, and create only one
selection set, and uses a general '..._click' function to reduce other code
multiplication...

"this combo code be rendered in the same look & feel" ... hmm.. gray text
and a black right "arrow"?
File Added: fuse.combo_04.diff

----------------------------------------------------------------------

Comment By: Fredrick Meunier (fredm)
Date: 2009-03-04 12:19

Message:
You are right that the combo code doesn't require any extra code to be
written. The biggest issue for me is that it isn't rendered in the same way
as the joystick type code (and support the same keyboard selection
behaviour etc.).

The flipside to the autogeneration in the existing form is that the
entries are duplicated between the combo entries in options.dat and the
code that uses them.

I'm not really talking about the GTK+ dialogs, just the widget version. I
am sure it is possible to improve the combo boxes there.

Is it possible to make this combo code be rendered in the same look & feel
with the same keyboard behaviour as the joystick style widget ui? I am sure
the GTK+ UI is OK.

Any ideas for removing the combo label duplication between the dat file
and the rest of the c source?

----------------------------------------------------------------------

Comment By: Fredrick Meunier (fredm)
Date: 2009-03-04 11:54

Message:
"I think the combo ends up being a different look and feel to the other
selection from list of choices type dialogs, but doesn't seem to add
anything new?"

 - hmm... it adds at least one thing:
you don't need to write any code to use "selection", just set up a Combo
option in 'options.dat' and 'settings.dat', and the code autogenerated...

With GTK+ UI, the joystick selection code is not so correct, because we
cannot force 'menu factory', to show the 'selected' item. So, if you open
the dialog, you always see the first item in the 'combo box' (e.g.
'Joystick Fire').

Anyway, the Combo is an 'option entry', so you can put it on an option tab
and the code is reusable. The joystick selection stuff is a 'submenu' plus
some 'individual' code, so you can put it into a menu tree and you have to
write the code 'by hand'.

----------------------------------------------------------------------

Comment By: Marek Januszewski (specu)
Date: 2009-02-25 18:23

Message:
I'm monitoring the changes to ui/gtk, as this is what ui/win32's structure
is most similar to, and will catch up on all changes eventually.

One other thing I would like to ask when adding stuff to widget is to the
extent possible think about guis that don't have keyboard, but joystick
only

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=596650&aid=2637346&group_id=91293