#12 ssh invalid password when password not in target path

closed
nobody
None
1
2011-02-06
2010-12-18
No

I prefer not to set the ssh password in my conf file. Either I set the FTP_PASSWORD in the environment or have ssh prompt for it.

The current behavior of duply is to always include the FTP_PASSWORD variable as part of the duplicity command. If the password is not in the target path, then duply assigns FTP_PASSWORD=’’. This prevents the use of an already assigned FTP_PASSWORD, since the command line overrides the environment variable. Second, it also prevents the prompted of a password if it is not set, since duplicity/ssh will use FTP_PASSWORD=‘’ as the password and not prompt the user.

I suggest to not pass FTP_PASSWORD if it is already set, OR if it is not set and no password is specified in the target path. In the second case, the user will be prompted for the password.

As a hack, I commented out line 1549 of duply to prevent FTP_PASSWORD from being passed to duplicity and it worked fine for my two scenarios.

Setup:
System Rescue CD 1.6.4
duplicity 0.6.11
duply 1.5.4.1

Discussion

  • ede
    ede
    2010-12-19

    I see where you are going. But why don't you simply set the duply conf variable
    TARGET_PASS
    in the environment running duply. That should work out of the box.

    I will retag this as a feature request. Maybe I'll add a password prompt in a later version.

    ede

     
  • ede
    ede
    2010-12-19

    • priority: 5 --> 1
    • status: open --> open-postponed
     
  • ede
    ede
    2011-02-06

    • status: open-postponed --> closed
     
  • ede
    ede
    2011-02-06

    regarding the prompt I made up my mind. FTP_PASSWORD is now only set if a password was configured resulting in a prompt if it was not.

    change is in 1.5.4.3dev snapshot or the next release. please test

    regards ede