Learn how easy it is to sync an existing GitHub or Google Code repo to a SourceForge project! See Demo

Close

#54 Check return codes everywhere

closed-rejected
nobody
None
5
2011-02-15
2010-12-11
Markus Elfring
No

Some checks for return codes are missing.

Examples:
Would you like to add more error handling for return values from "SysAllocStringByteLen" like in the constructor "MakeAnsi" and from "ftell" in the member function "HexFile::Open"?
http://frhed.svn.sourceforge.net/viewvc/frhed/trunk/FRHED/AnsiConvert.cpp?revision=476&view=markup
http://frhed.svn.sourceforge.net/viewvc/frhed/trunk/FRHED/HexFile.cpp?revision=782&view=markup

Discussion

  • Tim Gerundt
    Tim Gerundt
    2010-12-14

    Do you maybe want write a ptach for this item, too? :)

     
  • Tim Gerundt
    Tim Gerundt
    2010-12-14

    > Would you like to reduce the efforts for error code checking by an
    > exception class hierarchy?

    In PHP5 and VB.net I like using try/catch! :)

     
  • Kimmo Varis
    Kimmo Varis
    2010-12-18

    Those return values CAN be checked. I'm not doing that but can review a patch.

     
  • Kimmo Varis
    Kimmo Varis
    2011-02-15

    • status: open --> closed
     
  • Kimmo Varis
    Kimmo Varis
    2011-02-15

    No patch so closing.

     
  • Kimmo Varis
    Kimmo Varis
    2011-02-15

    • status: closed --> closed-rejected