Menu
▾
▴
[Freevo-tracker] [ freevo-Bugs-1801929 ] Crash when selecting Music item with special characters
|
From: SourceForge.net <no...@so...> - 2007-09-26 19:31:34
|
Bugs item #1801929, was opened at 2007-09-25 12:55 Message generated for change (Comment added) made by duncanwebb You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=446895&aid=1801929&group_id=46652 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: core Group: 1.7.3 >Status: Pending >Resolution: Invalid Priority: 5 Private: No Submitted By: Dylan Hall (dylan77) Assigned to: Nobody/Anonymous (nobody) Summary: Crash when selecting Music item with special characters Initial Comment: While browsing my music collection Freevo (1.7.3) crashes. Crash log from main-0.log attached. ---------------------------------------------------------------------- >Comment By: Duncan Webb (duncanwebb) Date: 2007-09-26 21:31 Message: Logged In: YES user_id=104395 Originator: NO I can't reproduce this problem, it was an old problem that was fixed and seems to still be fixed. Do you have a file in you distro, the path may be different? /usr/lib/python2.4/site-packages/freevo/sitecustomize.py What I have tried is to create the directories as you posted and they worked fine with of without cover.jpg files in them. I went one step further and created the same directory encoded in utf-8 and iso-8859-15 and both directories where shown correctly in freevo, but not from ls. The only remaining suggestion is that you try a test install of the current svn version of freevo. There's a how to in the wiki. ---------------------------------------------------------------------- Comment By: Dylan Hall (dylan77) Date: 2007-09-26 14:11 Message: Logged In: YES user_id=1898378 Originator: YES LOCALE isn't specified in local_conf.py. The value from /usr/share/freevo/freevo_config.py is LOCALE='iso-8859-15'. I have attached a tar.gz file of a subset of my Music collection, it just contains the directories, and one cover.jpg file, which seems to be sufficient to reproduce the crash. Interestingly, the crash only occurs when there is a cover.jpg file present in the directory with the special character in it's name. > ls | od -c 0000000 B e c k - O d e l a y \n B e 0000020 n H a r p e r \n B i c R u n 0000040 g a \n B j 366 r k - D e b u t 0000060 \n B l a c k S a b b a t h \n B 0000100 o b D y l a n \n C a r o u s e 0000120 l - C a r o u s e l \n C h r 0000140 i s R e a - T h e R o a 0000160 d T o H e l l \n C l a n n a 0000200 d \n C o l d p l a y \n C o l l e 0000220 c t i v e S o u l - C o l 0000240 l e c t i v e S o u l \n C r e 0000260 e d - M y O w n P r i s 0000300 o n \n C r o w d e d H o u s e 0000320 - R e c u r r i n g D r e 0000340 a m \n D a n n y E l f m a n <remaining output removed> I have modified /usr/lib/python2.4/site-packages/freevo/skins/main/skin_utils.py as suggested. This prevents Freevo from crashing while browsing the directory, but it also prevents the cover art displaying for the directory with the special character. Thanks, Dylan File Added: Music.tar.gz ---------------------------------------------------------------------- Comment By: Duncan Webb (duncanwebb) Date: 2007-09-25 19:28 Message: Logged In: YES user_id=104395 Originator: NO There is not much I can do with this bug report as it does not contain quite enough information. I need to know how to reproduce this bug to fix it and since I don't have you music collection this could be difficult. You can do this: ls /freevo/music-test/ | od -c 0000000 l a t i n 1 - B 344 h \n u n i c o 0000020 d e - B 303 244 h \n 0000030 And try changing this: skins/main/skin_utils.py @ line 96 image = load_imagecache['thumb://%s' % item_image] if not image: image = osd.loadbitmap('thumb://%s' % item_image) load_imagecache['thumb://%s' % item_image] = image to: image = load_imagecache['thumb://%s' % str(item_image)] if not image: image = osd.loadbitmap('thumb://%s' % str(item_image)) load_imagecache['thumb://%s' % str(item_image)] = image Also need to know what has been set as your LOCALE in local_conf.py ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=446895&aid=1801929&group_id=46652 |