[Freevo-tracker] [ freevo-Bugs-2936634 ] no more woven in twisted.web 9

[SourceForge.net <no...@so...>]

Bugs item #2936634, was opened at 2010-01-21 23:13
Message generated for change (Comment added) made by duncanwebb
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=446895&aid=2936634&group_id=46652

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: webserver
Group: 1.9.x
>Status: Pending
>Resolution: Accepted
Priority: 5
Private: No
Submitted By: A C G Mennucc (mennucc)
Assigned to: Nobody/Anonymous (nobody)
Summary: no more woven in twisted.web 9

Initial Comment:
the recently released Twisted Web 9.0.0 does not contain the subpackage 'woven' anymore. This breaks the webserver,  in freevo/www/web_types.py .  a.

----------------------------------------------------------------------

>Comment By: Duncan Webb (duncanwebb)
Date: 2010-01-28 12:12

Message:
Thanks Guys, patch applied to all files at r11648.

I doubt that FreevoPage is used outside freevo as it looks like test code.

----------------------------------------------------------------------

Comment By: Jason Rumney (jrumney)
Date: 2010-01-26 15:48

Message:
I too just got around to fixing this after a Debian update broke things a
couple of weeks ago. I didn't notice that it wasn't used anywhere, and
tried replacing it with nevow.rend.Page in web_types.py (this may be an
option if it turns out some third party plugin uses FreevoPage after all). 
In the htdocs directory, I found 5 files that imported page from
twisted.web.woven - none of them appear to use it: fileinfo.rpy,
guidechannel.rpy, guide.rpy, proginfo.rpy and vlcwin.rpy

----------------------------------------------------------------------

Comment By: A C G Mennucc (mennucc)
Date: 2010-01-21 23:35

Message:
also

--- /usr/share/freevo/htdocs/guide.rpy~	2009-02-19 18:59:44.000000000
+0100
+++ /usr/share/freevo/htdocs/guide.rpy	2010-01-21 23:29:00.274594734
+0100
@@ -32,7 +32,6 @@
 import sys, string
 import time
 
-from twisted.web.woven import page
 
 import config
 import util.tv_util as tv_util


----------------------------------------------------------------------

Comment By: A C G Mennucc (mennucc)
Date: 2010-01-21 23:27

Message:
the solution is simple: delete the import , and the class FreevoPage , that
is not used anywhere. See patch. a.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=446895&aid=2936634&group_id=46652