Re: [freetel-oslec] oslec into mainline kernel
Free software and hardware for telephony
Brought to you by:
drowe67
From: Tzafrir C. <tza...@xo...> - 2008-05-31 22:56:32
|
This time with the patch On Sun, Jun 01, 2008 at 01:08:31AM +0300, Tzafrir Cohen wrote: > On Thu, May 15, 2008 at 03:11:30AM +0930, David Rowe wrote: > > > David, I know that this is not the first time I ask you about this, but > > > what would it take to get OSLEC into mainline kernel? > > > > Including Oslec in the Linux kernel is fine with me (in fact it would be > > an honour!). I am not sure what is required from my side..... > > So let's start with the small technical steps required for submission. > > I installed sparse on my system and used 'make C=2' in the 'kernel' svn > directory. And the errors I originally got were (with base path stripped): oslec_wrap.c:398:38: warning: Using plain integer as NULL pointer oslec_wrap.c:403:27: warning: incorrect type in assignment (incompatible argument 2 (different address spaces)) oslec_wrap.c:403:27: expected int ( [usertype] *write_proc )( ... ) oslec_wrap.c:403:27: got int ( static [toplevel] *<noident> )( ... ) oslec_wrap.c:404:28: warning: incorrect type in assignment (incompatible argument 2 (different address spaces)) oslec_wrap.c:404:28: expected int ( [usertype] *write_proc )( ... ) oslec_wrap.c:404:28: got int ( static [toplevel] *<noident> )( ... ) > > There were a few small issues. Here's a patch to fix them. > > The text would also probably require re-indentation and such. > Also: if we want to submit to mainline kernel, maybe move the required > files from spandsp on to the kernel directory? The kernel cannot depend > on userspace spandsp. > > For instance, here is the oslec/ subdirectory I use in the Debian > package: > > oslec/Kbuild > oslec/spandsp/fir.h > oslec/spandsp/mmx.h > oslec/spandsp/bit_operations.h > oslec/spandsp/echo.h > oslec/echo.c > oslec/oslec-ctrl-panel.sh > oslec/oslec_wrap.c > oslec/oslec.h -- Tzafrir Cohen icq#16849755 jabber:tza...@xo... +972-50-7952406 mailto:tza...@xo... http://www.xorcom.com iax:gu...@lo.../tzafrir |