Menu
▾
▴
[Freeorion-programmers] [ freeorion-Bugs-2920657 ] Special Character on First Line of Stringtable Causes Errors
|
From: SourceForge.net <no...@so...> - 2010-04-13 19:53:41
|
Bugs item #2920657, was opened at 2009-12-24 04:33 Message generated for change (Comment added) made by geoffthemedio You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=544942&aid=2920657&group_id=75752 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Client >Group: Latest Subversion >Status: Closed >Resolution: None Priority: 7 Private: No Submitted By: Marc GS (marcgarsan) Assigned to: Nobody/Anonymous (nobody) Summary: Special Character on First Line of Stringtable Causes Errors Initial Comment: Spanish translation file esp_stringtable.txt for version 0.3.13 (at least) is not sinchronized with english version plus has special spanish character "ñ", so all texts are wrong visualized. ---------------------------------------------------------------------- >Comment By: Geoff Topping (geoffthemedio) Date: 2010-04-13 12:53 Message: This still occurs with the latest SVN for me. Adding "ñ" to the first line of eng_stringtable.txt causes all strings in the UI to be error messages. ---------------------------------------------------------------------- Comment By: Zach Laine (tzlaine) Date: 2010-04-13 12:50 Message: Please check the file again and report any existing crashes; otherwise, I'm calling this fixed. ---------------------------------------------------------------------- Comment By: Geoff Topping (geoffthemedio) Date: 2009-12-25 16:33 Message: I committed to SVN a modified version of the stringtable you attached that includes a bunch of missing strings. Unfortunately, unless someone volunteers to do so, we don't have any way to check the quality of translations before releases or any other time. The translations are provided, but not guaranteed to be complete or accurate, and won't be until we get closer to v1.0, when we'll make translations a higher priority. Before then, the english stringtable will be changing quite a bit, making maintaining translations of it difficult. Crashes related to missing strings have been mostly fixed in SVN. They're not easy to track down unless someone reports a crash, but most of them have been fixed. There's no way to objectively verify that source code is "correct", but we can try to fix reported bugs. The hanging issue with the stringtable isn't due to missing strings, but rather was due to a malformed string: the SERVER_WONT_START entry, which had an opening multiline string token ''' but no closing token. Adding ''' to the end of that string fixed the hang at startup. The hang started happening after I replaced the ñ in Español at the top of the stringtable file with ny (or something else similar). This is likely because having the ñ on the first line was causing the whole stringtable's contents to be not read, so the malformed string later wasn't being processed. Subsequent lines having ñ or not doesn't seem to make a difference. The hang from the malformed '''-enclosed string seems to be a boost regex issue, although I might be mistaken. Regardless, it's not unreasonable to require stringtables to be properly formatted... The remaining unexplained issue is why ñ on the first line of the stringtable causes the entire contents to be ignored, however. ---------------------------------------------------------------------- Comment By: Marc GS (marcgarsan) Date: 2009-12-25 15:26 Message: The are two problems with esp_stringtable.txt. One is that of "ñ" character. The other one is a lot of missing strings that hangs the game on start. I think any cause of hang is a bug. Maybe this game is a collaborative software but there must be some people that verifies the correctness of the source code (including translating text files) before a new release is launched. Maybe you can't control when is correct or not to print a "ñ", "á", "é", "í", "ó" or "ú", but you should not allow to happen one wrong translating text file hangs your application. ---------------------------------------------------------------------- Comment By: Geoff Topping (geoffthemedio) Date: 2009-12-25 11:02 Message: I've played around with this a bit more. It seems that some instances of adding ñ to the stringtable cause problems, but others don't. I've added an ñ to the Vision text, and it displays fine, but adding in other places causes all the strings to be not read and displayed as errors, or causes FreeOrion to hang when starting up. I'm not sure why some work and some don't. For now, if translating to spanish, check after each modification involving a ñ to verify that it still works... ---------------------------------------------------------------------- Comment By: wrwrwr (wrwrwr) Date: 2009-12-25 10:35 Message: With Spanish I get an error instead of every string, this does not happen with other languages, so there is something. Maybe some encoding issue? ---------------------------------------------------------------------- Comment By: Geoff Topping (geoffthemedio) Date: 2009-12-24 21:35 Message: The various language stringtables do get out of date if not actively maintained, and there are few people acitively maintaining all the stringtables. If you're able to provide updated ones, please do, although the forums of wiki would be a better place, as out of date stringtables isn't really a bug. I'm not sure what you mean by "all texts are wrong visualized", though. The ñ character displays fine for me in-game when included in the stringtable file. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=544942&aid=2920657&group_id=75752 |