#229 crash when stars=99999999999999

Latest Subversion
closed-fixed
nobody
Server (27)
8
2006-03-04
2006-02-17
Egamma1
No

On the Single Player galaxy creation screen, typing "9"
repeatedly in the box, the clicking the "galaxy type"
pulldown causes FO to crash.

My system:
Windows XP Home SP2, all the latest patches
2.8Ghz P4, 512 MB RAM

Oh, and I did try it a second time, the second time my
entire computer froze.

Discussion

  • Egamma1
    Egamma1
    2006-02-17

    I think this is the crash file

     
    Attachments
  • Geoff Topping
    Geoff Topping
    2006-02-18

    Logged In: YES
    user_id=913462

    When I try this, as soon as I click on the galaxy shape
    drop-list, the number of stars changes to 10.

    Did you press enter before clicking galaxy shape, or just
    click it after typing 9 a bunch...?

    Maybe it's an overflow issue... can you try various powers
    of 2 (2^16, 2^32, 2^64, 2^128), etc, and perhaps some
    negative numbers as well?

    Are you sure you typed just 9's, and no spaces or letters or
    other symbols?

     
  • Egamma1
    Egamma1
    2006-02-18

    Logged In: YES
    user_id=1160073

    I'm positive it was just 9's. I tried 999, and it changed to
    500. I tried 9999, and it changed to 500. I tried 999999,
    and it crashed regardless of whether I hit enter or clicked
    the galaxy dropdown--I believe it's the handling of the
    number that's causing the crash.

    I tried -999, and it went to 10. I tried -99999999, and it
    crashed, same as the large positive interger.

    Why not simply limit the field size to 3 numerals? That
    seems to be the easiest way to prevent overflows or whatever.

     
  • Geoff Topping
    Geoff Topping
    2006-02-18

    Logged In: YES
    user_id=913462

    999999 changes to 500 for me...

    You're sure you're not doing anything special to make it
    crash after entering the number?

    What version are you using?

     
  • Egamma1
    Egamma1
    2006-02-19

    Logged In: YES
    user_id=1160073

    I'm using 0.3 RC3, the latest one.

    I tried the same thing with 100000000 (or similar), and it
    caused my computer to freeze--it's a large number problem.
    Why not limit the input box to 3 characters?

     
  • Geoff Topping
    Geoff Topping
    2006-02-19

    Logged In: YES
    user_id=913462

    > Why not limit the input box to 3 characters?

    tzlaine would have to decide for keeps, but:
    -Limiting an entry box to a certain number of digits rather
    than a certain numerical range after entering is probably
    more complicated
    -Limiting a single entry box to three digits and not others
    would probably be even more complicated
    -We might want to allow more than 999 stars at some point
    -There's probably a deeper issue that needs resolving, that
    when resolve would make such an change unnecessary.

     
  • Tom Bell
    Tom Bell
    2006-02-22

    Logged In: YES
    user_id=629255

    Using RC3 on windows 2000

    I entered all 9's and then hit enter and it crashed.

    This has been re-producable.

    T

     
  • Zach Laine
    Zach Laine
    2006-03-03

    • priority: 5 --> 8
     
  • Zach Laine
    Zach Laine
    2006-03-04

    Logged In: YES
    user_id=729903

    Fixed in GG Subversion. (The fix wasn't in the FreeOrion code
    itself, but in GG, the GUI library FreeOrion uses.)

     
  • Zach Laine
    Zach Laine
    2006-03-04

    • status: open --> closed-fixed