Work at SourceForge, help us to make it a better place! We have an immediate need for a Support Technician in our San Francisco or Denver office.

Close

#24 Cleanup of AbstractTestCase

closed-accepted
Nicholas Cull
None
5
2001-06-19
2001-06-17
Dan Milstein
No

Some rewriting (and refactoring), of the testcase/
directory. Specifically, I added extensive javadoc
comments to AbstractTestCase (to explain how to
subclass it), removed some unused variables, and
changed the method signature for showTestResults (which
involved then changing all of the subclasses). It
looked like the code was halfway between old,
customized tests, and the junit style (and the cvs log
supported this theory). So I pushed them a bit closer
to junit (though they could use some more work).

Discussion

  • Dan Milstein
    Dan Milstein
    2001-06-17

    Code reorg for AbstractTestCase + friends

     
    Attachments
  • Nicholas Cull
    Nicholas Cull
    2001-06-19

    Logged In: YES
    user_id=137221

    Sounds about right (*grin*). The patch looks good -- will
    check in shortly.

    Nicholas.

     
  • Nicholas Cull
    Nicholas Cull
    2001-06-19

    • assigned_to: nobody --> run2000
     
  • Nicholas Cull
    Nicholas Cull
    2001-06-19

    • status: open --> closed-accepted
     
  • Nicholas Cull
    Nicholas Cull
    2001-06-19

    Logged In: YES
    user_id=137221

    Done. This is now in CVS, as at 19 June 2001.

     
  • Nicholas Cull
    Nicholas Cull
    2001-06-19

    Logged In: YES
    user_id=137221

    PS. This also made it into the FreeMarker 1.6.1 release that
    just went out the door tonight.