I am pretty puzzled, so I guess there is a misunderstanding. Reading
> again what I wrote maybe I should rephrase: There was a property in a
> test class that was only used inside a single function, so it cluttered
> the properties list where it had nothing to do. Was this the reason for
> your response? Otherwise you have to help me here.
Actually I saw the diff of your review and I see that you have made the
code quite concise at lot of places.
one example is in ConfigurationRoomFactory.
I meant i could have inlined the variables value/method instead of creating
variables. thus making the code concise and nice looking.
On Tue, 4 Jun 2013 10:32:46 +0530
premkumar bhaskal <pbhaskal@...> wrote:
> Actually I saw the diff of your review and I see that you have made
> the code quite concise at lot of places.
> one example is in ConfigurationRoomFactory.
> I meant i could have inlined the variables value/method instead of
> creating variables. thus making the code concise and nice looking.
Ah ok. Yes, I tend to inline small single-call functions. I know that I
sometimes deviate from Andrea and other people here, maybe I should
impose this a bit less. I prefer concise code, because it is less
intimidating on first view, and I usually parse it faster.
ConfigurationRoomFactory is a special case, because I found the code
flow too difficult. Basically the ScenarioListing leaked exceptions
where the calling code should not be interested (the calling code simply
gets an empty list of scenarios on errors). And after fixing that, the
function consisted of a single line that pretty much duplicated the
name of the listing function, so I inlined it.