Work at SourceForge, help us to make it a better place! We have an immediate need for a Support Technician in our San Francisco or Denver office.

Close

#3 Incorrect Bug in EraseUnprotectedAddress

open
nobody
None
5
2012-10-26
2006-03-24
Dave Craggs
No

EraseUprotectedAddress in RWTn3270StreamParser.

The first line is counter++. From what I can see this
is incorrect as counter is incremented in setBufferAddress.

On entering the routine, counter is currently pointing
at ORDER_EUA. The next two characters comprise of the
address. The counter is incremented in
SetBufferAddress, so incrementing it here is incorrect.

Interestingly, the routine repeatToAddress also has
counter++ as the first line, but commented out.

Discussion

  • Robbie Stone
    Robbie Stone
    2006-04-04

    Logged In: YES
    user_id=26825

    Thank you for reporting this.

    1. What does this affect during use?
    2. How can I reproduce it?

    Thanks.

     
  • Dave Craggs
    Dave Craggs
    2006-04-04

    Logged In: YES
    user_id=334742

    What happens is that the routine will try to get the
    address from the wrong two bytes and a corruption will
    occur.

    Testing this is a problem, you need a TN3270 feed that
    gives an EraseUnprotectedAddress.

    Dave

     
  • Robbie Stone
    Robbie Stone
    2006-04-04

    Logged In: YES
    user_id=26825

    Dave,

    I'm going to check a fix into the repository to clear up
    this bug. Although I don't have a way to confirm it easily,
    I do see that what it is doing is incorrect.

    Please check the CVSweb interface to ensure the fix has
    posted, and then pull a new copy from HEAD.

    Thanks,

    Robbie