Re: [Freeglut-developer] Github pull requests

[Diederick C. N. <dc...@gm...>]

Hi Vinnie,

Indeed one person just reminded me, turns out we still need to review
his contribution. I have asked John as he is familiar with that exotic
hardware i believe.

The other open pull request should just be good to execute,
centralizing the Callback function type declarations in one place. I
don't think we have discussed this issue here tho, so here goes:

Guys, right now we have a situation where the callback function types
are declared twice in the code, once in fg_interal.h and once in the
freeglut_Std and freeglut_ext headers. It is good to put this in one
file. This pull request, https://github.com/dcnieho/FreeGLUT/pull/24,
provides that, moving the declarations to their own header.
Looks like a good plan to me. However, if approved, i'll simply copy
over the declarations from fg_internal.h and fix up formatting a bit
further manually myself. I am a stickler for well organized code that
forms nice visual blocks, in the pull request all extra space was
removed and I don't like it.

All the best,
Dee

On Mon, May 4, 2015 at 8:41 PM, Vinnie Simonetti <rcm...@ho...> wrote:
> Dee,
>
>
>
> Have you gotten any time to review/merge any of the pull requests on Github?
>
>
>
> Vinnie
>
>
> ------------------------------------------------------------------------------
> One dashboard for servers and applications across Physical-Virtual-Cloud
> Widest out-of-the-box monitoring support with 50+ applications
> Performance metrics, stats and reports that give you Actionable Insights
> Deep dive visibility with transaction tracing using APM Insight.
> http://ad.doubleclick.net/ddm/clk/290420510;117567292;y
> _______________________________________________
> Freeglut-developer mailing list
> Fre...@li...
> https://lists.sourceforge.net/lists/listinfo/freeglut-developer
>