From: Vinnie S. <rcm...@ho...> - 2014-08-03 19:41:52
|
Sorry for the delay. Looks fine to me, though should it still be set in config.h or should the version template be removed from there? Vinnie From: Diederick C. Niehorster [mailto:dc...@gm...] Sent: Wednesday, July 30, 2014 11:58 PM To: FreeGLUT developers list Subject: Re: [Freeglut-developer] Fwd: [FreeGLUT] Is there a good reason for VERSION_MAJOR etc to migrate to cmake? (#15) Hi Guys, Any other comments on the below, or should I go ahead and pull it in? Thanks, Dee On Fri, Jul 25, 2014 at 4:07 PM, Nigel Stewart <nig...@gm... <mailto:nig...@gm...> > wrote: I put a pull request out on github, feedback appreciated. https://github.com/dcnieho/FreeGLUT/pull/17 - Nigel On Fri, Jul 25, 2014 at 1:53 PM, Diederick C. Niehorster <dc...@gm... <mailto:dc...@gm...> > wrote: Hi Nigel, I guess this is a good solution as well. A comment in the CMake file can make sure that this gets updated too. Are there other issues related to non-cmake builds you'd like to discuss? cmake is setting a bunch of flags, and you contacted me yesterday about one of those. Better put it all on the lst tho ;) Thanks, Dee On Fri, Jul 25, 2014 at 10:16 AM, Nigel Stewart <nig...@gm... <mailto:nig...@gm...> > wrote: Just to clarify, config.h is typically avoided in the production environments I'm familiar with. It's generally preferable for a build to fail, rather than disable functionality due to a missing dependency, or whatever. I do sympathize with using cmake to manage the version number in resource files and the like, but it would be nice for FreeGLUT to "just build" as it always has, if there was a fg_version.h with something like: #ifndef VERSION_MAJOR #define VERSION_MAJOR 3 #endif ... In this way the build system can _optionally_ specify the version info. - Nigel On Fri, Jul 25, 2014 at 11:55 AM, Vinnie Simonetti <rcm...@ho... <mailto:rcm...@ho...> > wrote: First off: I found that it already is written to config.h Second: This is true. Though the only place I see it being used is fg_state.c. So in my view, outside of reducing the distance from definition to usage, I don't know why we even have it in any build environments. Vinnie _____ Date: Fri, 25 Jul 2014 11:43:24 +1000 From: nig...@gm... <mailto:nig...@gm...> To: fre...@li... <mailto:fre...@li...> Subject: Re: [Freeglut-developer] Fwd: [FreeGLUT] Is there a good reason for VERSION_MAJOR etc to migrate to cmake? (#15) I think the difference is that config.h is platform-specific, whereas fg_version.h is not and bypasses cmake in other build environments. - Nigel On Fri, Jul 25, 2014 at 11:40 AM, Vinnie Simonetti <rcm...@ho... <mailto:rcm...@ho...> > wrote: I replied on Github <https://github.com/dcnieho/FreeGLUT/issues/15> . "Why generate a fg_version.h when it can just be written to config.h which cmake (and others) already generate?” Vinnie From: Diederick C. Niehorster [mailto:dc...@gm... <mailto:dc...@gm...> ] Sent: Thursday, July 24, 2014 9:25 PM To: FreeGLUT developers list; Nigel Stewart Subject: [Freeglut-developer] Fwd: [FreeGLUT] Is there a good reason for VERSION_MAJOR etc to migrate to cmake? (#15) Hi Guys, Please see the below. What do others feel? All the best, Dee ---------- Forwarded message ---------- From: Nigel Stewart <not...@gi... <mailto:not...@gi...> > Date: Fri, Jul 25, 2014 at 9:04 AM Subject: Re: [FreeGLUT] Is there a good reason for VERSION_MAJOR etc to migrate to cmake? (#15) To: dcnieho/FreeGLUT <Fre...@no... <mailto:Fre...@no...> > Cc: "Diederick C. Niehorster" <dc...@gm... <mailto:dc...@gm...> > What I mean by "established build toolchain" is that I can think of at least three source trees building and using freeglut that are not using cmake and are not likely to be migrated. So needing to manage the version numbering in each one of those seems like a pain. I was wondering if you'd consider a patch that would generate a fg_version.h from cmake, which would be checked-in and #included from fg_internal.h ? — Reply to this email directly or view it on GitHub <https://github.com/dcnieho/FreeGLUT/issues/15#issuecomment-50097452> . <https://github.com/notifications/beacon/1787673__eyJzY29wZSI6Ik5ld3NpZXM6QmVhY29uIiwiZXhwaXJlcyI6MTcyMTg2OTQ3MiwiZGF0YSI6eyJpZCI6Mzc4MzcwNDR9fQ==--e00b11bf1909f6d7090513f2bdbd4506b3b1c982.gif> ------------------------------------------------------------------------------ Want fast and easy access to all the code in your enterprise? Index and search up to 200,000 lines of code with a free copy of Black Duck Code Sight - the same software that powers the world's largest code search on Ohloh, the Black Duck Open Hub! Try it now. http://p.sf.net/sfu/bds _______________________________________________ Freeglut-developer mailing list Fre...@li... <mailto:Fre...@li...> https://lists.sourceforge.net/lists/listinfo/freeglut-developer ------------------------------------------------------------------------------ Want fast and easy access to all the code in your enterprise? Index and search up to 200,000 lines of code with a free copy of Black Duck Code Sight - the same software that powers the world's largest code search on Ohloh, the Black Duck Open Hub! Try it now. http://p.sf.net/sfu/bds _______________________________________________ Freeglut-developer mailing list Fre...@li... <mailto:Fre...@li...> https://lists.sourceforge.net/lists/listinfo/freeglut-developer ------------------------------------------------------------------------------ Want fast and easy access to all the code in your enterprise? Index and search up to 200,000 lines of code with a free copy of Black Duck Code Sight - the same software that powers the world's largest code search on Ohloh, the Black Duck Open Hub! Try it now. http://p.sf.net/sfu/bds _______________________________________________ Freeglut-developer mailing list Fre...@li... <mailto:Fre...@li...> https://lists.sourceforge.net/lists/listinfo/freeglut-developer ------------------------------------------------------------------------------ Want fast and easy access to all the code in your enterprise? Index and search up to 200,000 lines of code with a free copy of Black Duck Code Sight - the same software that powers the world's largest code search on Ohloh, the Black Duck Open Hub! Try it now. http://p.sf.net/sfu/bds _______________________________________________ Freeglut-developer mailing list Fre...@li... <mailto:Fre...@li...> https://lists.sourceforge.net/lists/listinfo/freeglut-developer ------------------------------------------------------------------------------ Want fast and easy access to all the code in your enterprise? Index and search up to 200,000 lines of code with a free copy of Black Duck Code Sight - the same software that powers the world's largest code search on Ohloh, the Black Duck Open Hub! Try it now. http://p.sf.net/sfu/bds _______________________________________________ Freeglut-developer mailing list Fre...@li... <mailto:Fre...@li...> https://lists.sourceforge.net/lists/listinfo/freeglut-developer ------------------------------------------------------------------------------ Want fast and easy access to all the code in your enterprise? Index and search up to 200,000 lines of code with a free copy of Black Duck Code Sight - the same software that powers the world's largest code search on Ohloh, the Black Duck Open Hub! Try it now. http://p.sf.net/sfu/bds _______________________________________________ Freeglut-developer mailing list Fre...@li... <mailto:Fre...@li...> https://lists.sourceforge.net/lists/listinfo/freeglut-developer |