#43 Use a blank string rather than nil in empty props

closed
nobody
None
5
2012-11-09
2012-11-09
Kent
No

Empty properties (such as "TZID:") will now have a blank string set as the value, rather than nil. This only applies when ICAL_ALLOW_EMPTY_PROPERTIES is 1.

This fixes issues with Outlook where events will occasionally have a VTIMEZONE that looks like this:

BEGIN:VTIMEZONE
TZID:
X-ENTOURAGE-CFTIMEZONE:
BEGIN:STANDARD
TZNAME:Standard
RRULE:FREQ=YEARLY;INTERVAL=1;BYDAY=SU;BYMONTH=1;BYSETPOS=1;WKST=SU
TZOFFSETFROM:-0700
TZOFFSETTO:-0800
DTSTART:16010101T010000
END:STANDARD
BEGIN:DAYLIGHT
TZNAME:Daylight
RRULE:FREQ=YEARLY;INTERVAL=1;BYDAY=SU;BYMONTH=1;BYSETPOS=2;WKST=SU
TZOFFSETFROM:-0800
TZOFFSETTO:-0700
DTSTART:16010101T030000
END:DAYLIGHT
END:VTIMEZONE

Using a blank string rather than null allows the time zone to be found successfully later.

Discussion

  • Kent
    Kent
    2012-11-09

     
    Attachments
  • Allen Winter
    Allen Winter
    2012-11-09

    • status: open --> closed
     
  • Allen Winter
    Allen Winter
    2012-11-09

    committed in r1137

    thanks Kent.