Work at SourceForge, help us to make it a better place! We have an immediate need for a Support Technician in our San Francisco or Denver office.

Close

#39 Fixed leak in parser_get_param_name

closed-accepted
nobody
None
5
2012-10-07
2012-09-26
Kent
No

Fixes a leak when parsing parameters with quotes such as TZID="BLAHBLAHBLAH"

The normal path is for parameters to be unquoted, so no string copy is made and a pointer to the middle of an existing buffer is returned. However, quoted strings make a copy and return a new buffer. I changed the unquoted path to also return a new buffer, then ensured that the buffer is released.

I also removed the buf_value paramter from the function since nothing was using it.

Discussion

  • Kent
    Kent
    2012-09-26

  • Allen Winter
    Allen Winter
    2012-10-07

    • status: open --> closed-accepted
     
  • Allen Winter
    Allen Winter
    2012-10-07

    committed in r1132.