Work at SourceForge, help us to make it a better place! We have an immediate need for a Support Technician in our San Francisco or Denver office.

Close

#36 Fix libicalss parser for non-Intel architectures

closed-accepted
nobody
None
5
2012-04-12
2012-04-12
Anonymous
No

The test suite fails on ARM and PowerPC because the libicalss lexer performs unput(EOF) which is not permitted. On these architectures, this gets interpreted as unput(255), creating an extra token which then causes the parser to return a syntax error.

Instead, the lexer should just ignore EOF and not attempt to unput it. The input stream will remain at EOF and the lexer will return an EOF as the next token as needed.

Ubuntu build failure logs are here (we run the test suite as part of the build): https://launchpad.net/ubuntu/+source/libical/0.48-1ubuntu2/+build/3398815 https://launchpad.net/ubuntu/+source/libical/0.48-1ubuntu2/+build/3398816 https://launchpad.net/ubuntu/+source/libical/0.48-1ubuntu2/+build/3398818

Discussion

  • Allen Winter
    Allen Winter
    2012-04-12

    • status: open --> closed-accepted
     
  • Allen Winter
    Allen Winter
    2012-04-12

    Thanks for this patch too.

    committed in r1127