Work at SourceForge, help us to make it a better place! We have an immediate need for a Support Technician in our San Francisco or Denver office.

Close

#34 Commas in quoted strings are split into multiple values

closed-accepted
nobody
None
5
2012-04-07
2012-03-31
Kent
No

The following example is incorrectly parsed:

BEGIN:VEVENT
X-TEST;VALUE=URI:\"geo:10.123456,-70.123456\"
END:VEVENT

X properties allow multiple values, but the quotes are ignored. The result is two properties: "geo:10.123456 and -70.123456". The attached patch fixes this.

However I'm not sure if the correct output should be "geo:10.123456,-70.123456" or without the quotes. If you remove the VALUE=URI parameter then the result becomes escaped as \"geo:10.123456\,-70.123456\". These are separate issues based on how icalvalue handles different property types and I'm not sure if they're behaving as intended or not.

Discussion

  • Kent
    Kent
    2012-03-31

     
    Attachments
  • Allen Winter
    Allen Winter
    2012-04-07

    • status: open --> closed-accepted
     
  • Allen Winter
    Allen Winter
    2012-04-07

    thanks for the patch
    committed in r11224