#33 Added ACKNOWLEDGED property

closed-accepted
nobody
None
5
2012-04-12
2012-03-31
Kent
No

Apple is using the ACKNOWLEDGED property in VALARMs in iCloud. Their extension proposal is documented here: http://tools.ietf.org/html/draft-daboo-valarm-extensions-03

There are some other properties listed there as well, but I haven't run across any of them in use yet.

This patch adds ACKNOWLEDGED to the property list in design-data so that libical round-trips the data correctly.

Discussion

  • Kent
    Kent
    2012-03-31

  • Allen Winter
    Allen Winter
    2012-04-07

    Kent,

    This patch doesn't compile for me on Fedora Linux with gcc 4.6.3
    Here's the error. Please fix and send a new patch
    -Allen

    [ 7%] Building C object src/libical/CMakeFiles/ical.dir/icalderivedproperty.o
    /home/allen/projects/freeassociation/trunk/libical/build-trunk-gcc/src/libical/icalderivedproperty.c:78:2: error: ‘ICAL_ACKNOWLEDGED_PROPERTY’ undeclared here (not in a function)
    /home/allen/projects/freeassociation/trunk/libical/build-trunk-gcc/src/libical/icalderivedproperty.c:301:6: warning: conflicting types for ‘icalproperty_set_acknowledged’ [enabled by default]
    /home/allen/projects/freeassociation/trunk/libical/build-trunk-gcc/src/libical/icalderivedproperty.c:285:4: note: previous implicit declaration of ‘icalproperty_set_acknowledged’ was here
    /home/allen/projects/freeassociation/trunk/libical/build-trunk-gcc/src/libical/icalderivedproperty.c: In function ‘icalproperty_get_exdate’:
    /home/allen/projects/freeassociation/trunk/libical/build-trunk-gcc/src/libical/icalderivedproperty.c:1421:2: warning: passing argument 1 of ‘icalproperty_get_first_parameter’ discards ‘const’ qualifier from pointer target type [enabled by default]
    /home/allen/projects/freeassociation/trunk/libical/src/libical/icalproperty.h:88:16: note: expected ‘struct icalproperty *’ but argument is of type ‘const struct icalproperty *’
    make[2]: *** [src/libical/CMakeFiles/ical.dir/icalderivedproperty.o] Error 1
    make[1]: *** [src/libical/CMakeFiles/ical.dir/all] Error 2

     
  • Kent
    Kent
    2012-04-11

    What's the build command you're using? I just did a clean checkout on OS X with clang and it worked just fine. make should be calling scripts/mkderivedproperties.pl, which reads the design-data file I patched and generates icalderivedproperty.c. Judging from that error I'm guessing that the script wasn't run.

     
  • Allen Winter
    Allen Winter
    2012-04-12

    Kent,

    Are you using the cmake or the automake build system? for me, the build definitly fails using cmake.
    I'll see if I can find out why.

    -Allen

     
  • Kent
    Kent
    2012-04-12

    I usually use automake. I just tried a clean checkout of trunk and applied the patch, then ran cmake CMakeLists.txt; make and it builds fine for me there as well. Strange :)

     
  • Allen Winter
    Allen Winter
    2012-04-12

    Thanks for the patch.
    The problems I mentioned were my fault. had forgotten to make distclean from an old autotools build.

    commit r1128

     
  • Allen Winter
    Allen Winter
    2012-04-12

    • status: open --> closed-accepted