#286 Mixed Lists aren't handled properly

closed-fixed
nobody
5
2008-08-01
2008-07-24
Bob Armstrong
No

Should be able to mix lists together such as in

1. First Item
2. Second Item
* bullet level 2 item 1
* bullet level 2 item 2
o bullet level 3 item 1
3. Third Item

Formatter assumes all list styles never are mixed.

Discussion

  • John Davidson
    John Davidson
    2008-07-24

    Logged In: YES
    user_id=1602893
    Originator: NO

    This is a bug that has existed for a long time with the original parser. This has been fixed in the new parser. This will be left open for the time being, if someone wants to submit a patch it will be accepted, otherwise it will most likely not be corrected.

     
  • Bob Armstrong
    Bob Armstrong
    2008-07-24

    Logged In: YES
    user_id=2138948
    Originator: YES

    Checked this against build 243 and it still wasn't working correctly.
    Have developed a patch, but no nunit tests yet, just manual ones. Contains a fix for another list problem as well that I haven't reported yet. Will run my fix for a while on a site before submitting.

    ... Bob

     
  • John Davidson
    John Davidson
    2008-07-24

    Logged In: YES
    user_id=1602893
    Originator: NO

    Existing unit tests are in FormatterTests.cs::ListTests - note that there are no cases of mixed lists and that the </li> on nested list items is not in the correct place.

     
  • John Davidson
    John Davidson
    2008-08-01

    Logged In: YES
    user_id=1602893
    Originator: NO

    Build 2.1.0.248 (r1032) has a fix that allows mixed lists to function correctly. Patch submitted by Bob Armstrong.

    Thanks

     
  • John Davidson
    John Davidson
    2008-08-01

    • status: open --> closed-fixed