#387 syntax error: VALRGIND

1.3.0
closed-invalid
Erik
5
2014-03-21
2011-10-03
2bits sfbugs
No

VALGRIND, detector of memory leaks, is misspelled VALRGIND in flac-1.2.1 thru HEAD, in files

test/Makefile.in
test/Makefile.am

The result is that ./configure --enable-valgrind-testing doesn't cause any subsequent make check
tests to be run through Valgrind. Fix the spelling and you fix the issue. The next thing you'll find
when Valgrind gets it's first set of commands is that its command line argument for number of places
to show in a stack trace maxes out at 50 now, not 100 as is coded in the test scripts. So another patch
there (I set it to 20 because it's not going to segfault anyway), and its testing time. My ruby patch looks like:

inreplace 'test/Makefile', 'VALRGIND', 'VALGRIND'

Dir['test/test_*.sh'].each do |testprog|
inreplace testprog, '--num-callers=100', '--num-callers=20'
end

Hey thanks for a great codec you guys.

Discussion

  • Ralph Giles
    Ralph Giles
    2013-01-03

    Thanks for the report. The valrgind mis-spelling has been fixed independently.

    As to the second problem, are you saying your valgrind errors out with --num-callers=100? The manpage for my valgrind (3.8.1) says the maximum is 500 (a lot more reasonable the 50!) and I've never seen a problem.

    It would be nice to remove it altogether by I suspect the default (12) is insufficient for C++ code.

     
  • Erik
    Erik
    2014-03-21

    The 'VALRGIND' typo is long gone and --ebable-valgrind-tests seems to work as expected.

    Closing this.

     
  • Erik
    Erik
    2014-03-21

    • status: open --> closed-invalid
    • assigned_to: Erik
    • Group: --> 1.3.0