Learn how easy it is to sync an existing GitHub or Google Code repo to a SourceForge project! See Demo

Close

#341 fLaC magic id not being checked

closed-fixed
Josh Coalson
libFLAC (57)
6
2009-01-07
2008-11-04
Michael Schwendt
No

Something in the file decoder no longer checks for the "fLaC" magic id at the beginning of FLAC input files.

Affected are the "flac -d" command-line program as well as the libraries.

For example, FLAC decoder happily accepts arbitrary MP3 files (also without ID3 tags) and starts decoding them, which leads to [thousands of] LOST_SYNC and BAD_HEADER errors.

It ought to verify that the "fLaC" magic is present and reject incompatible input files.

Discussion

  • Josh Coalson
    Josh Coalson
    2009-01-02

    • labels: --> libFLAC
    • priority: 5 --> 6
    • assigned_to: nobody --> jcoalson
    • status: open --> open-accepted
     
  • Josh Coalson
    Josh Coalson
    2009-01-07

    fixed in cvs. fLaC is not required to decode but first sync error hit on mp3 gives a readable error message

     
  • Josh Coalson
    Josh Coalson
    2009-01-07

    • status: open-accepted --> closed-fixed