#297 metaflac --export-cuesheet-to minor bug

open-accepted
Josh Coalson
metaflac (17)
2
2007-09-11
2007-08-31
Egor
No

metaflac --export-cuesheet-to generates a cuesheet with erroneous FILE type:
FILE "name.flac" FLAC
should be
FILE "name.flac" WAVE

Some programs (e.g., foobar2000 and Nero Burning ROM) strictly parse CUE files, and the only allowed types (as in the original Goldenhawk's documentation) are WAVE, AIFF and MP3. WAVE filetype is okay for flac-aware programs.

Discussion

  • Egor
    Egor
    2007-08-31

    • priority: 5 --> 2
     
  • Josh Coalson
    Josh Coalson
    2007-08-31

    Logged In: YES
    user_id=78173
    Originator: NO

    I don't think this is a bug with flac, it is describing the type it actually is. otherwise, why not use AIFF for the type? flac doesn't know what the original format was.

    also the type can easily be tweaked at export time, e.g.

    metaflac --export-cuesheet-to=- file.flac | sed -e 's/ FLAC$/ WAVE/'

     
  • Egor
    Egor
    2007-09-03

    Logged In: YES
    user_id=1648141
    Originator: YES

    Well, the filetype field is not a free form descriptor, it must be one of the predefined set. I don't want to nitpick - you've done the great job, but "file ... flac" doesn't conform to the so-called standard cuesheet syntax. Though, advanced users will fix a cuesheet easily.

     
  • Josh Coalson
    Josh Coalson
    2007-09-11

    • status: open --> open-accepted