#174 [PATCH] OS/2 was not supported

closed-fixed
Josh Coalson
None
4
2007-08-31
2005-06-29
Anonymous
No

Contrary to documentation, flac is not ported to OS/2. The patches below
fill part of the gap; the remaining patches are sent in a separate
message, since they are OS/2-specific. Notable features:

wildcard processing, and responce file (`flac -0 @arg_list' will read
arguments from file arg_list);
handling of binary stdin and stdout;
rename() failing if target exists addressed;
src/test_streams/main.c has a bug: a binary file should be fopen()ed
with "b" flag on ALL systems; I did not try to fix this, and added
yet another special case;
test/test_flac.sh assumes that ':' is not a special character in a filename;
test/test_metaflac.sh assumes that /bin/sh.exe or /bin/sh exist;
test/test_seeking.sh assumes that ogg support is present.

All the applicable tests succeed with these patches.

Discussion

  • patches

     
    Attachments
  • Josh Coalson
    Josh Coalson
    2005-08-09

    • assigned_to: nobody --> jcoalson
    • status: open --> open-accepted
     
  • Josh Coalson
    Josh Coalson
    2005-09-02

    Logged In: YES
    user_id=78173

    some of this I will be able to patch. part of this patch is
    unusable because it breaks other platforms; those sections
    need to be predicated on a detection of OS/2 which I don't know
    exactly how to do.

     
  • Josh Coalson
    Josh Coalson
    2005-09-03

    • priority: 5 --> 4
     
  • Josh Coalson
    Josh Coalson
    2005-09-03

    • priority: 4 --> 5
     
  • Josh Coalson
    Josh Coalson
    2005-09-03

    Logged In: YES
    user_id=78173

    ok, checked in to CVS, thanks.

     
  • Josh Coalson
    Josh Coalson
    2005-09-03

    • priority: 5 --> 4
    • status: open-accepted --> open-fixed
     
  • Josh Coalson
    Josh Coalson
    2007-08-31

    Logged In: YES
    user_id=78173
    Originator: NO

    I think all the ones I know how to fix are fixed now, please reopen another bug if current CVS has problems still.

     
  • Josh Coalson
    Josh Coalson
    2007-08-31

    • status: open-fixed --> closed-fixed