#141 --import-vc-from only applies to one file

closed-fixed
Josh Coalson
metaflac (17)
6
2006-11-14
2004-12-10
Anonymous
No

I'm using Metaflac to tag a bunch of files.

Usually I do something like this:

$ metaflac --set-vc-property=PERFORMER="Georg
Solti" *.flac

and that does what it looks like: it adds a PERFORMER
property to each FLAC file in this folder.

Sometimes, for various reasons, I don't want to use
--set-vc-property; instead, I want to use
--import-vc-from. But a line like this doesn't do what
it appears to:

$ echo "PERFORMER=Georg Solti" | metaflac
--import-vc-from=- *.flac

That does something very different: it adds a PERFORMER
property to the first file (ASCIIbetically) in this
folder only. The others are unchanged.

There's nothing in the metaflac(1) manpage to indicate
that this feature doesn't work on multiple files, or
that it works differently than --set-vc-property.
(There's also no warning or error printed to indicate
that it didn't set the property on most of the files
you specified.)

- ken@bitpoetry.com

Discussion

  • Logged In: NO

    It appears to do this for stdin only:
    "--import-vc-from=myfile *.flac" works fine but
    "--import-vc-from=- *.flac" tags only one file.

     
  • Josh Coalson
    Josh Coalson
    2004-12-30

    Logged In: YES
    user_id=78173

    that is exactly right. the bug is that metaflac is
    opening/reading/closing the comment file for each FLAC
    file, which won't work for stdin. this may also be a
    problem for other commands that accept stdin. I will fix
    it for the next release.

    Josh

     
  • Josh Coalson
    Josh Coalson
    2004-12-30

    • status: open --> open-accepted
     
  • Josh Coalson
    Josh Coalson
    2005-01-25

    Logged In: YES
    user_id=78173

    have to push the fix out for this to after FLAC 1.1.2 due
    to time constraints...

    Josh

     
  • Josh Coalson
    Josh Coalson
    2006-11-13

    • priority: 5 --> 6
     
  • Josh Coalson
    Josh Coalson
    2006-11-14

    Logged In: YES
    user_id=78173

    ok, making it work for multiple input files is too much pain
    for 1.1.3, for now I at least fixed the docs to reflect it
    and added an error for it in metaflac.

     
  • Josh Coalson
    Josh Coalson
    2006-11-14

    • status: open-accepted --> closed-fixed