Re: [Firebird-devel] The metadata crash

[Mike N. <ta...@al...>]

Claudio Valderrama C. wrote:
> Hello, I need a suggestion. I don't know what's the best place to stop
this
> issue:
> ALTER DOMAIN DUNNO SET;

Looking at dsql/parse.y it indeed seems wierd.

Forgive me if my understanding is completely wrong, my (E)BNF is a little
rusty, but if I interpret it right it would allow e.g.:

ALTER DOMAIN CURRENT_TIME DROP CONSTRAINT DROP DEFAULT TO foobar;

which I think would be completely nonsense.

I think the errors are:

alter_clause : [snip] DOMAIN alter_column_name alter_domain_ops

which should probably be:

alter_clause : DOMAIN  simple_column_name alter_domain_ops

It also seems to me that the "alter_domain_ops" rule allows infinite
recursion until terminated by an alter_domain_op.

alter_domain_ops : alter_domain_op
   | alter_domain_ops alter_domain_op


The IB6 Lang. Ref. doesn't mention the TO keyword, which is made legal in
parse.y(1578). If it is an extension it seems like a reasonable extension to
me, but in that case it should at least be documented.

If my understanding of this problem is correct, it should be fixed in
parse.y.

Would you like to have a look at it?

/Mike