When trying to build an installable snapshot of Firebird 22.214.171.12486, I
found the following errors in the inno setup script FirebirdInstall_20.iss:
a missing semicolon
two variables with the wrong type (AnsiString is working)
I am using InnoSetup Compiler 5.4.0 and ISPP 5.3.9
The unified diff file:
Do Jan 20 14:29:22 2011
@@ -825,7 +825,7 @@
if not CheckWinsock2 then begin
result := False;
//By default we want to install and confugure,
//unless subsequent analysis suggests otherwise.
@@ -1001,8 +1001,8 @@
//Compare firebird.conf with the one we just saved.
//If they match then we can remove the saved one.
- FirebirdConfStr: String;
- SavedConfStr: String;
+ FirebirdConfStr: AnsiString;
+ SavedConfStr: AnsiString;
LoadStringFromFile( GetAppPath+'\firebird.conf', FirebirdConfStr );
LoadStringFromFile( FirebirdConfSaved, SavedConfStr );
From: Paul Reeves <preeves@ib...> - 2011-01-20 14:49:15
On Thursday 20 January 2011 at 14:49 christian.waldmann@... wrote:
> When trying to build an installable snapshot of Firebird 126.96.36.19986, I
> found the following errors in the inno setup script FirebirdInstall_20.iss:
> a missing semicolon
Thanks. That has been missing for many years :-)
> two variables with the wrong type (AnsiString is working)
The problem here is that the 2.1.n innosetup scripts are written to work with
InnoSetup 5.2.3 (it is mentioned in the header.) In general we try not to
change the toolchain within a major release version.
At some point soon it will be necessary to consider making everything work
with both the latest version of innosetup (probably the unicode version) but
that work hasn't started yet. It is currently planned for the first public
release v3.0 alpha. If anyone has any thoughts on this I would be happy to
hear them. One question is whether we gain anything with unicode. And what do
we lose with unicode?
Anyway before we go to release 2.1.4 I'll take a look at using AnsiString
instead of String.
Specialists in Firebird support