Work at SourceForge, help us to make it a better place! We have an immediate need for a Support Technician in our San Francisco or Denver office.

Close

#148 default fink to x86_64 and clang on 10.7+

closed-accepted
nobody
None
5
2011-07-07
2011-06-10
Jack Howarth
No

The attached patch modifies fink cvs to..

1) build only the x86_64 distribution on10.7 and later.
2) abort bootstrap if java sdk isn't installed and request user to do so.
3) add support for path-prefix-clang compiler wrapper symlinks to cause cc/gcc to use clang and c++/g++ to use clang++ on 10.7 and later.

Discussion

  • Jack Howarth
    Jack Howarth
    2011-06-10

    patch to add path-prefix-clang support on 10.7 and later

     
  • Jack Howarth
    Jack Howarth
    2011-06-10

    Note that the section...

    Index: perlmod/Fink/PkgVersion.pm

    RCS file: /cvsroot/fink/fink/perlmod/Fink/PkgVersion.pm,v
    retrieving revision 1.661
    diff -r1.661 PkgVersion.pm
    1154c1154
    < "make\n";
    ---
    > "make CC=gcc CXX=g++ \n";

    is present in allow perlmods to build with the clang compilers (otherwise the gcc compilers are called with a full path defeating path-prefix-clang).

     
  • Daniel Macks
    Daniel Macks
    2011-06-10

    Features #1 and #3 done. Not Comment 1 (special perl control) pending core decision about perhaps getting away from apple's perl--fink's would presumably not hard-code that path(?). Not feature #2 until we sort out whether we really need java so soon.

     
  • Jack Howarth
    Jack Howarth
    2011-06-10

    The problem is that any configure script (such as that in libiconv) that tests for java will trigger its installation. We *do not* want this to occur in the middle of a package build. Hence my patch pre-emptively tests for java and aborts the installation if not present so it can be completed. Not that if the abort happens, the user will already be faced with an automatic SU download anyway.

     
  • Jack Howarth
    Jack Howarth
    2011-06-11

    log showing javac trigger in fink bootstrap

     
  • Jack Howarth
    Jack Howarth
    2011-06-11

    The attached log shows where the current fink cvs bootstrap (sans my java sdk check) triggers the java sdk download in Lion...

    checking for Java compiler... javac
    checking for jar... jar

    Note that configure incorrectly reports javac as being available so a race condition exists in the libiconv package build during the bootstrap. The user must complete the installation of Java SDK before the libiconv tries to use the nonexistent javac.

    Again we *do not* want to trigger the SU download of Java SDK from within a package build but need to pre-empively test for javac and abort the bootstrap if not present so that the user can safely complete the installation of before reattempting the fink bootstrap.

     
  • Daniel Macks
    Daniel Macks
    2011-07-06

    PkgVersion.pm CC and GCC to make added (Comment #1)

     
  • Daniel Macks
    Daniel Macks
    2011-07-06

    extracted from prefix-clang-default-v2.diff

     
    Attachments
  • Daniel Macks
    Daniel Macks
    2011-07-07

    java check committed.

     
  • Daniel Macks
    Daniel Macks
    2011-07-07

    • status: open --> closed-accepted