#130 Validation check for *Script no-op

open
Max Horn
None
2
2011-10-28
2005-02-14
Chris Dolan
No

As documented in the email referenced below, there are
a ton of ways maintainers signal a no-op in the
CompileScript or InstallScript. For example,
'CompileScript: echo "nothing to compile"'. Better
form is to silently return a true value via
'CompileScript: /usr/bin/true'. This is better because
it's less verbose (who cares if there is nothing to
compile?) and it reduces the English text for when we
internationalize Fink someday (inevitable, I think).

The attached patch adds a .info validation step that
recommends that the maintainer change no-ops to
/usr/bin/true. It only checks in pedantic mode
(verbosity > 3).

Email reference:
http://sf.net/mailarchive/message.php?msg_id=10116957

Feedback is appreciated. If this change is deemed good
by people, I'll cvs commit it myself.

Discussion

  • Chris Dolan
    Chris Dolan
    2005-02-14

    Validation.pm patch

     
    Attachments
  • Daniel Macks
    Daniel Macks
    2005-02-14

    Logged In: YES
    user_id=535292

    Please don't apply this (in its current form) until -devel
    resolves the issue of making validation checks dependent on
    verbosity level.

     
  • Chris Dolan
    Chris Dolan
    2005-02-14

    • priority: 5 --> 2
    • assigned_to: nobody --> chrisdolan
     
  • Chris Dolan
    Chris Dolan
    2005-02-14

    Logged In: YES
    user_id=50365

    Understood, Dan. This is obviously a low-priority patch.

     
  • Max Horn
    Max Horn
    2011-10-28

    • assigned_to: chrisdolan --> fingolfin